Remove Grafana monitoring service (#5750) #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StepanBrychta
commented
Jun 13, 2024
Comment on lines
-52
to
-64
| module "ecr_nginx_grafana" { | ||
| source = "./repo_pair" | ||
|
|
||
| namespace = local.namespace | ||
| repo_name = "nginx_grafana" | ||
|
|
||
| description = "An nginx image for reverse proxying Grafana" | ||
|
|
||
| providers = { | ||
| aws.ecr_public = aws.ecr_public | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not really sure what this was for but I didn't find any references to it and I suspect it wasn't used, so hopefully it's safe to remove.
There was a problem hiding this comment.
This creates both a public and private ECR repo. I believe it is safe to remove.
kenoir
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing and why?
wellcomecollection/platform#5750
This removes all infrastructure related to the Grafana monitoring service.
terraform plandiffGitHub doesn't let me paste the full diff here because it exceeds the maximum allowed length, but this destroys 34 resources, mostly in the
monitoring/terraform/stack/folder.