Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alpine from sbt_wrapper #434

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Remove alpine from sbt_wrapper #434

merged 1 commit into from
Jul 12, 2024

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Apr 16, 2024

What's changing and why?

This change moves from using an alpine os version of sbt-wrapper, to using the slightly larger dependencies included ubuntu version.

We've seen places where tests fail because there are missing dependencies. This change resolves that issue at the cost of increased data transfer in CI.

See: https://buildkite.com/wellcomecollection/storage-service/builds/1748#018ee239-8e8c-4f39-b46a-7e8009748236/183-550

The new container image reports:

root@61480c352c5a:/repo# uname -a
Linux 61480c352c5a 6.6.16-linuxkit #1 SMP Fri Feb 16 11:54:02 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux
root@61480c352c5a:/repo# cat /etc/
Display all 107 possibilities? (y or n)
root@61480c352c5a:/repo# cat /etc/o
opt/        os-release
root@61480c352c5a:/repo# cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.4 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.4 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy
root@61480c352c5a:/repo# exit

Note

This is currently pushed with the tag 760097843905.dkr.ecr.eu-west-1.amazonaws.com/wellcome/sbt_wrapper:no_alpine. We should test this in projects outside the storage service and then push it to untagged to be picked up generally by all projects that use this in CI to run scala tests.

@kenoir kenoir requested a review from agnesgaroux April 16, 2024 14:33
Copy link
Contributor

@paul-butcher paul-butcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as it is, but If data transfer is a concern, I see that it now leaves CURL in place, rather than removing it.

I wonder if this might be a job for a multi-stage build - one that installs curl and downloads the zip, then the next one copies the zip from the first then installs everything else and does the rest of the install_sbt stuff

@kenoir kenoir merged commit 88a755d into main Jul 12, 2024
4 checks passed
@kenoir kenoir deleted the rk/update-sbt-wrapper branch July 12, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants