Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing and why?
This change moves from using an alpine os version of sbt-wrapper, to using the slightly larger dependencies included ubuntu version.
We've seen places where tests fail because there are missing dependencies. This change resolves that issue at the cost of increased data transfer in CI.
See: https://buildkite.com/wellcomecollection/storage-service/builds/1748#018ee239-8e8c-4f39-b46a-7e8009748236/183-550
The new container image reports:
Note
This is currently pushed with the tag
760097843905.dkr.ecr.eu-west-1.amazonaws.com/wellcome/sbt_wrapper:no_alpine
. We should test this in projects outside the storage service and then push it to untagged to be picked up generally by all projects that use this in CI to run scala tests.