dnfbase: Fix substitutions

[bcl]

Branching for Fedora 40 revealed a problem with using substitutions in the GPG key name, @AdamWill fixed this by setting them on the Base object which appears to be the correct way to do it.

Remove the per-repo kludge and set releasever and basearch on the Base variables so they are used everywhere.

[bcl]

Fixes #1379

[AdamWill]

I am not actually sure that setting basearch this way works. At least, the two bits of code in dnf5 itself that set releasever this way - here and here - do not set basearch the same way, which seems like a warning flag. I'll try it out and see what happens.

[AdamWill]

well, I tried it this way, and it seems to be working. I do kinda feel like I want to ask dnf5 folks what exactly is going on here and if this is the right way, though - @jan-kolarik @m-blaha ? edit: for more context, my original PR was #1379 which just added this approach for releasever but kept the substitutions , @bcl extended it to this.

[jan-kolarik]

well, I tried it this way, and it seems to be working. I do kinda feel like I want to ask dnf5 folks what exactly is going on here and if this is the right way, though - @jan-kolarik @m-blaha ? edit: for more context, my original PR was #1379 which just added this approach for releasever but kept the substitutions , @bcl extended it to this.

The current situation looks as expected from the DNF point of view. You set up the variables, and then when the repositories are created, they are substituted with the real values in sack.create_repos_from_reposdir().

However, I couldn't find proper documentation for this in the current API docs, so I've added it to our existing issue, and we'll strive to provide better documentation soon.

[coveralls]

Pull Request Test Coverage Report for Build 7933079822

Details

• 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 43.521%

---

Totals
Change from base Build 7808681794:	-0.02%
Covered Lines:	1614
Relevant Lines:	3500

---

💛 - Coveralls

[AdamWill]

@jan-kolarik thanks! Just to be clear - when you say "The current situation looks as expected from the DNF point of view", do you mean the "current situation" as in "the changes in this pull request are correct"?

[jan-kolarik]

@jan-kolarik thanks! Just to be clear - when you say "The current situation looks as expected from the DNF point of view", do you mean the "current situation" as in "the changes in this pull request are correct"?

Yes, sorry for my cumbersome expressions 😛

[j-mracek]

Looks like a good place for setting vars.

[j-mracek]

I am not actually sure that setting basearch this way works. At least, the two bits of code in dnf5 itself that set releasever this way - here and here - do not set basearch the same way, which seems like a warning flag. I'll try it out and see what happens.

The links refers to a commandline overrides from options. The patch looks OK.

[bcl]

Can't figure out what's up with github. The tests pass, and I updated the checkout version like it suggested but it still says waiting for status. Merging it anyway.