Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup #143

Merged
merged 4 commits into from
Oct 16, 2024
Merged

code cleanup #143

merged 4 commits into from
Oct 16, 2024

Conversation

kalhankoul96
Copy link
Collaborator

No description provided.

@@ -151,7 +144,7 @@ def connect(self, other, edge, kwargs=None):
return new_conns

def get_connection_from_tensor(self, tensor):
print(self.tensor_to_conn)
# print(self.tensor_to_conn)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these print stmt are commented out instead of being deleted, is there a reason why we wanna keep these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept some if I thought it would make debugging easier later

Copy link
Collaborator

@bobcheng15 bobcheng15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the prints are only commented out instead of deleted.

Copy link
Collaborator

@bobcheng15 bobcheng15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalhankoul96 kalhankoul96 merged commit 2151dc7 into mapping_to_cgra Oct 16, 2024
1 check passed
@kalhankoul96 kalhankoul96 deleted the print_cleanup branch October 16, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants