Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable sparse formal check #126

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

bobcheng15
Copy link
Collaborator

Removed setting of environment variable that skips formal check while mapping alu operation (since the issue of floating point formal checks failing has been fixed by Jack)

@bobcheng15 bobcheng15 requested a review from kalhankoul96 April 1, 2024 18:50
@bobcheng15 bobcheng15 self-assigned this Apr 1, 2024
@bobcheng15 bobcheng15 changed the base branch from master to mapping_to_cgra April 1, 2024 18:50
@bobcheng15 bobcheng15 marked this pull request as ready for review April 1, 2024 18:58
Copy link
Collaborator

@kalhankoul96 kalhankoul96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. make sure it passes aha flow

@bobcheng15 bobcheng15 merged commit c4ec544 into mapping_to_cgra Apr 1, 2024
2 checks passed
@bobcheng15 bobcheng15 deleted the reenable_sparse_formal_check branch April 1, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants