-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse metamapper #117
Merged
Merged
Sparse metamapper #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bobcheng15
commented
Feb 5, 2024
- Updated the graphs that contains the smax operation (all relu graphs) to update the op name from max to smax, and update the argument they use to pass the constant.
- Update the mat_elemadd_leakyrelu_exp graph to use a single exp node to represent the exponential operation, which will rely on metamapper to perform mapping.
- Updated parse_dot.py to add code that generates the coreir specification for compute nodes.
- Updated parse_dot.py to call metamapper/scripts/map_app.py to perform mapping on the generated coreir specification.
- Updated parse_dot.py to add support for parsing the complex op mapping generated by the metamapper.
- Updated parse_dot.py to fix the issue where it is trying to remap the already rewritten arrayvals when the second time the rewrite_arrays function is invoked.
- Updated compute_node.py to remove all the hard-coded logic that generates the opcode for the alu. Also added code to generate the FIFO enable configuration register value base on the ports picked by metamapper
- Updated compute_node.py to add a function to parse the mapped coreir specification for the opcode and the input ports a compute_node will use.
- Updated connection logic to compute node in intersect_node.py, reduce_node.py, compute_node.py, and read_scanner_node.py to get rid of the hard-coded connection port name. It now uses the information generated by metamapper instead.
…mapper to map the pe
…logic, and dedicated reduce primitive mapping logic
…per generates, clean up printing statement in read scanner node
…o enabled alu mapping for adder in vector_reduce
… to collat dir, update compute node to parse json file in collat dir
…apping operation with constant using metamapper
…ap the complex op
…op alus, also update the connection logic to allow destination port specification by metamapper
…r all apps in the regression, further cleanup WIP
kalhankoul96
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.