forked from milvus-io/pymilvus
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from milvus-io:master #1
Open
pull
wants to merge
102
commits into
weiliu1031:master
Choose a base branch
from
milvus-io:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.65.0 to 4.66.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tqdm/tqdm/releases">tqdm's releases</a>.</em></p> <blockquote> <h2>tqdm v4.66.3 stable</h2> <ul> <li><code>cli</code>: <code>eval</code> safety (fixes CVE-2024-34062, GHSA-g7vv-2v7x-gj9p)</li> </ul> <h2>tqdm v4.66.2 stable</h2> <ul> <li><code>pandas</code>: add <code>DataFrame.progress_map</code> (<a href="https://redirect.github.com/tqdm/tqdm/issues/1549">#1549</a>)</li> <li><code>notebook</code>: fix HTML padding (<a href="https://redirect.github.com/tqdm/tqdm/issues/1506">#1506</a>)</li> <li><code>keras</code>: fix resuming training when <code>verbose>=2</code> (<a href="https://redirect.github.com/tqdm/tqdm/issues/1508">#1508</a>)</li> <li>fix <code>format_num</code> negative fractions missing leading zero (<a href="https://redirect.github.com/tqdm/tqdm/issues/1548">#1548</a>)</li> <li>fix Python 3.12 <code>DeprecationWarning</code> on <code>import</code> (<a href="https://redirect.github.com/tqdm/tqdm/issues/1519">#1519</a>)</li> <li>linting: use f-strings (<a href="https://redirect.github.com/tqdm/tqdm/issues/1549">#1549</a>)</li> <li>update tests (<a href="https://redirect.github.com/tqdm/tqdm/issues/1549">#1549</a>) <ul> <li>fix <code>pandas</code> warnings</li> <li>fix <code>asv</code> (<a href="https://redirect.github.com/airspeed-velocity/asv/issues/1323">airspeed-velocity/asv#1323</a>)</li> <li>fix macos <code>notebook</code> docstring indentation</li> </ul> </li> <li>CI: bump actions (<a href="https://redirect.github.com/tqdm/tqdm/issues/1549">#1549</a>)</li> </ul> <h2>tqdm v4.66.1 stable</h2> <ul> <li>fix <code>utils.envwrap</code> types (<a href="https://redirect.github.com/tqdm/tqdm/issues/1493">#1493</a> <- <a href="https://redirect.github.com/tqdm/tqdm/issues/1491">#1491</a>, <a href="https://redirect.github.com/tqdm/tqdm/issues/1320">#1320</a> <- <a href="https://redirect.github.com/tqdm/tqdm/issues/966">#966</a>, <a href="https://redirect.github.com/tqdm/tqdm/issues/1319">#1319</a>) <ul> <li>e.g. cloudwatch & kubernetes workaround: <code>export TQDM_POSITION=-1</code></li> </ul> </li> <li>drop mentions of unsupported Python versions</li> </ul> <h2>tqdm v4.66.0 stable</h2> <ul> <li>environment variables to override defaults (<code>TQDM_*</code>) (<a href="https://redirect.github.com/tqdm/tqdm/issues/1491">#1491</a> <- <a href="https://redirect.github.com/tqdm/tqdm/issues/1061">#1061</a>, <a href="https://redirect.github.com/tqdm/tqdm/issues/950">#950</a> <- <a href="https://redirect.github.com/tqdm/tqdm/issues/614">#614</a>, <a href="https://redirect.github.com/tqdm/tqdm/issues/1318">#1318</a>, <a href="https://redirect.github.com/tqdm/tqdm/issues/619">#619</a>, <a href="https://redirect.github.com/tqdm/tqdm/issues/612">#612</a>, <a href="https://redirect.github.com/tqdm/tqdm/issues/370">#370</a>) <ul> <li>e.g. in CI jobs, <code>export TQDM_MININTERVAL=5</code> to avoid log spam</li> <li>add tests & docs for <code>tqdm.utils.envwrap</code></li> </ul> </li> <li>fix & update CLI completion</li> <li>fix & update API docs</li> <li>minor code tidy: replace <code>os.path</code> => <code>pathlib.Path</code></li> <li>fix docs image hosting</li> <li>release with CI bot account again (<a href="https://redirect.github.com/cli/cli/issues/6680">cli/cli#6680</a>)</li> </ul> <h2>tqdm v4.65.2 stable</h2> <ul> <li>exclude <code>examples</code> from distributed wheel (<a href="https://redirect.github.com/tqdm/tqdm/issues/1492">#1492</a>)</li> </ul> <h2>tqdm v4.65.1 stable</h2> <ul> <li>migrate <code>setup.{cfg,py}</code> => <code>pyproject.toml</code> (<a href="https://redirect.github.com/tqdm/tqdm/issues/1490">#1490</a>) <ul> <li>fix <code>asv</code> benchmarks</li> <li>update docs</li> </ul> </li> <li>fix snap build (<a href="https://redirect.github.com/tqdm/tqdm/issues/1490">#1490</a>)</li> <li>fix & update tests (<a href="https://redirect.github.com/tqdm/tqdm/issues/1490">#1490</a>) <ul> <li>fix flaky notebook tests</li> <li>bump <code>pre-commit</code></li> <li>bump workflow actions</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tqdm/tqdm/commit/4e613f84ed2ae029559f539464df83fa91feb316"><code>4e613f8</code></a> Merge pull request from GHSA-g7vv-2v7x-gj9p</li> <li><a href="https://github.com/tqdm/tqdm/commit/b53348c73080b4edeb30b4823d1fa0d8d2c06721"><code>b53348c</code></a> cli: eval safety</li> <li><a href="https://github.com/tqdm/tqdm/commit/cc372d09dcd5a5eabdc6ed4cf365bdb0be004d44"><code>cc372d0</code></a> bump version, merge pull request <a href="https://redirect.github.com/tqdm/tqdm/issues/1549">#1549</a> from tqdm/devel</li> <li><a href="https://github.com/tqdm/tqdm/commit/e9f0c05097dc167031575391d83240d37556f098"><code>e9f0c05</code></a> use PyPI trusted publishing</li> <li><a href="https://github.com/tqdm/tqdm/commit/7323d5bcc9b032d525f9d6468a9713f5be9c4174"><code>7323d5b</code></a> slight makefile clean</li> <li><a href="https://github.com/tqdm/tqdm/commit/5306125133d76e0f9326d747d29781fefe273c77"><code>5306125</code></a> tests: bump pre-commit</li> <li><a href="https://github.com/tqdm/tqdm/commit/4a6fd4f690a4add231f4bef601521ed9bee513fb"><code>4a6fd4f</code></a> fix datetime.utcfromtimestamp py3.12 warning (<a href="https://redirect.github.com/tqdm/tqdm/issues/1519">#1519</a>)</li> <li><a href="https://github.com/tqdm/tqdm/commit/6f13759f4a0e1047a09732e72f6d07e44d3e6855"><code>6f13759</code></a> tests: fix macos notebook indentation</li> <li><a href="https://github.com/tqdm/tqdm/commit/3abcd2ac90ecb01ac7f64071af600f803eab6a21"><code>3abcd2a</code></a> tests: fix asv</li> <li><a href="https://github.com/tqdm/tqdm/commit/a4d15c8e2f6c7322c1a1cd1d845927f037281da1"><code>a4d15c8</code></a> tests: fix pandas warnings</li> <li>Additional commits viewable in <a href="https://github.com/tqdm/tqdm/compare/v4.65.0...v4.66.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tqdm&package-manager=pip&previous-version=4.65.0&new-version=4.66.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/milvus-io/pymilvus/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: yangxuan <[email protected]>
#2043 Signed-off-by: wayblink <[email protected]>
so that the error messages can correctly propagate Signed-off-by: Buqian Zheng <[email protected]>
It is to make the example consistent with https://milvus.io/docs/tls.md.If these changes look fine I can modify the other example as well --------- Signed-off-by: Nischay Yadav <[email protected]>
…e matrix (#2074) issue: #2067 Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: junjie.jiang <[email protected]>
issue: milvus-io/milvus#32707 milvus-io/milvus#30040 Signed-off-by: Wei Liu <[email protected]>
It is to make the example consistent with [https://milvus.io/docs/tls.md.](https://milvus.io/docs/tls.md.If). Signed-off-by: Nischay Yadav <[email protected]>
See also: #2067 Signed-off-by: yangxuan <[email protected]>
when providing sparse float vector using python dict/list, we allow the index/value to be wrapped in string: both `{1:0.1, 2:0.2}` and `{1:"0.1", "2": 0.2}` are acceptable. this is defined in `entity_is_sparse_matrix` but `sparse_rows_to_proto` doesn't respect this. This pr fixes this. Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: yangxuan <[email protected]>
/kind improvement issue: milvus-io/milvus#30436 link pr: #2055 Signed-off-by: SimFG <[email protected]>
Added grpc protocol to connection uri validation. Not having it was preventing grpc connections with the following error: <ConnectionConfigException: (code=1, message=Open local milvus failed, dir: grpc: is not exists)> --------- Signed-off-by: Bruno Faria <[email protected]> Signed-off-by: Bruno Faria <[email protected]> Co-authored-by: Bruno Faria <[email protected]>
issue: milvus-io/milvus#29419 as range search supported has been added to sparse index Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: MrPresent-Han <[email protected]> Co-authored-by: MrPresent-Han <[email protected]>
…rch (#2111) previous: ``` col.insert([[1, 2, 3], csr]) # ok if csr is a 3 row sparse object col.insert([[1, 2, 3], [csr1, csr2, csr2]]) # this is not ok ``` now: ``` col.insert([[1, 2, 3], [csr1, csr2, csr2]]) # ok if csr1/csr2/csr3 are all single row object ``` Signed-off-by: Buqian Zheng <[email protected]>
milvus-io/milvus#33327 Signed-off-by: lixinguo <[email protected]> Co-authored-by: lixinguo <[email protected]>
/kind improvement --------- Signed-off-by: longjiquan <[email protected]>
/kind improvement Signed-off-by: SimFG <[email protected]>
Signed-off-by: yhmo <[email protected]>
Signed-off-by: yhmo <[email protected]>
…#2134) @XuanYang-cn Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in #2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. Signed-off-by: rui zhang <[email protected]>
See also: #2134 Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
Index name and field name is already there for Index object, No need to get them from kwargs when drop ```python ivf_flat = Index(c, "embeddings", params, index_name="ivf_flat", construct_only=True) ivf_flat.drop() ``` --------- Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
related: #2129 Signed-off-by: MrPresent-Han <[email protected]> Co-authored-by: MrPresent-Han <[email protected]>
Signed-off-by: Cai Zhang <[email protected]>
related: #2292 Signed-off-by: MrPresent-Han <[email protected]> Co-authored-by: MrPresent-Han <[email protected]>
this check was added in #2257. this caused an test in milvus to fail. the test expects the error to be thrown on server side instead of sdk side. it is ok to check on sdk side but I choose to remove it to keep the behavior consistent and comfort the ut without modifying it. Failed test: https://github.com/milvus-io/milvus/blob/5b2658327d676453e8a251ffc3273f4a218fb278/tests/python_client/testcases/test_collection.py#L318 Signed-off-by: Buqian Zheng <[email protected]>
related: #2278 Signed-off-by: MrPresent-Han <[email protected]> Co-authored-by: MrPresent-Han <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
also fix schema comparison of tokenizer_params: tokenizer_params returned by the server is in string format, while the user may provide it in dict format. But this fix is not perfect and will likely fail when tokenizer_params become more complicate due to possible json key reordering. @XuanYang-cn any idea? tracking this issue in #2299 Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: yhmo <[email protected]>
issue: milvus-io/milvus#36966 Signed-off-by: Buqian Zheng <[email protected]>
… the schema (#2303) issue: milvus-io/milvus#36986 Signed-off-by: Buqian Zheng <[email protected]>
See also: milvus-io/milvus#36983 Signed-off-by: yangxuan <[email protected]>
…v supports null (#2281) #2276 --------- Signed-off-by: OxalisCu <[email protected]>
related: #2306 Signed-off-by: MrPresent-Han <[email protected]> Co-authored-by: MrPresent-Han <[email protected]>
related: #2306 Signed-off-by: MrPresent-Han <[email protected]> Co-authored-by: MrPresent-Han <[email protected]>
issue: milvus-io/milvus#37022 and milvus-io/milvus#37021 list of empty string is erroneously treated as sparse vector adding a check to explicitly require that, if the input data will be seen as sparse vector, its data type, if not scipy format, should be list of list or list of dict. Signed-off-by: Buqian Zheng <[email protected]>
issue: #milvus-io/milvus#36672 milvus-proto: milvus-io/milvus-proto#331 milvus: milvus-io/milvus#37033 Signed-off-by: Cai Zhang <[email protected]>
Fixed typo in comment of step 1 from "... buildin in ..." to "... is built-in to ..." Signed-off-by: Armaggheddon <[email protected]>
milvus-io/milvus#37196 Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: aoiasd <[email protected]>
issue: #2325 Signed-off-by: zhenshan.cao <[email protected]>
This PR updates several error messages for grammar and clarity. The changes include: Corrected "data should be a list of list" to "The data should be a list of lists" for better readability. Fixed grammar in "The data don't match with schema fields" to "The data doesn't match with schema fields." Corrected field name mismatch message from "The name of field don't match" to "The name of the field doesn't match." These improvements enhance the clarity and professionalism of error messages in the codebase.
related: #2328 Signed-off-by: MrPresent-Han <[email protected]> Co-authored-by: MrPresent-Han <[email protected]>
Signed-off-by: lentitude2tk <[email protected]>
… efficiency (#2334) milvus pr: milvus-io/milvus#37484 Signed-off-by: Cai Zhang <[email protected]>
Fix typo: change "UnSupported" to "Unsupported" Fix grama error: * _None entities, please provide valid entities_ to _'entities' must be a list, please provide valid entity data._ * _None rows, please provide valid row data._ to _'rows' must be a list, please provide valid row data._ Signed-off-by: NamCaoHai <[email protected]>
related: [#2332](#2332) --------- Signed-off-by: NamCaoHai <[email protected]>
milvus-io/milvus#35856 Signed-off-by: junjiejiangjjj <[email protected]>
Signed-off-by: Cai Zhang <[email protected]>
Signed-off-by: yangxuan <[email protected]>
issue: milvus-io/milvus#37031 --------- Signed-off-by: shaoting-huang <[email protected]>
issue: milvus-io/milvus#37622 Signed-off-by: Ubuntu <[email protected]> Co-authored-by: Ubuntu <[email protected]>
Signed-off-by: yhmo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )