Corrected InfoClick bug when using MeasureTool afterwards #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismayer
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Nice catch @sronveaux! Thanks for tackling these 2 problems at once.
Tested and reviewed ➡️ LGTM ➡️ please merge at will 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since addition of #367, after
InfoClickwas opened, using some other tools likeMeasureToolwould break at first click on the map.This is linked to the fact that the geometry drawn by the measure tool (points and lines) are returned by
forEachFeatureAtPixel. However, those aren't linked to any layer which madeviewPropsfail in this case.To correct it,
featureswhich are not assigned to a layer are not kept byforEachFeatureAtPixel.This PR also corrects another linked bug where the map click event was not unregistered properly when
InfoClickcomponent was closed. This was apparently reported some time ago. So this also fixes #285