Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Photon geocoder provider #410

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix Photon geocoder provider #410

merged 2 commits into from
Jul 23, 2024

Conversation

sronveaux
Copy link
Collaborator

This PR fixes the Photon geocoder provider. There were two problems with it :

  1. The URL has changed four years ago, even though the old one still works, it is a good idea to update it as stated on photon homepage
  2. Photon returns the bounding boxes with Y coordinates flipped which breaks the move to a selected place. A test was added to put the coordinates in the format expected by OpenLayers

chrismayer
chrismayer approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for tackling this. Looks good to me. Please merge at will...

@sronveaux sronveaux merged commit 1d86945 into wegue-oss:master Jul 23, 2024
1 check passed
@sronveaux sronveaux deleted the photon-extent-and-url branch July 23, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismayer chrismayer chrismayer approved these changes

@fschmenger fschmenger Awaiting requested review from fschmenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sronveaux @chrismayer