Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OpenLayers to v7.5.1 #346

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

chrismayer
Copy link
Collaborator

This upgrades the OpenLayers dependency to version 7.5.1 (current latest).

Since OpenLayers follows semantic versioning no problems or conflict should appear when upgrading, which can be verified with the official change logs:

Copy link
Collaborator

@sronveaux sronveaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made some tests with my personal app and I can confirm everything works flawlessly.

It will be great to have support of WebGL Vector Layers (for example) available inside Wegue. This opens once again a lot of new possibilities !

Just a question though, would it be useful to add a link to the full OpenLayers upgrade notes inside Wegue upgrade notes so that users would have the opportunity to trace all backwards incompatible changes from OL 6.4.3 to OL 7.5.1 and perhaps later ?
I know there is already a link to the release notes of V7 and perhaps this is enough...

This PR is indeed ready to merge from my point of view !

@chrismayer
Copy link
Collaborator Author

Thanks for your review and feedback @sronveaux. I just added another commit, which adds a link to the the full OpenLayers upgrade notes as suggested by you. I totally agree that this is a very useful resource in an upgrade process.

I also gave this a shot in a bigger real-life application and still detected no problems...so I am going to merge now.

Thanks again!

@chrismayer chrismayer merged commit e74c8e7 into wegue-oss:master Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants