Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prefix all short-name images for new Podman compatibility #26

Merged

Conversation

wiktor-k
Copy link
Contributor

@wiktor-k wiktor-k commented Aug 1, 2024

See: https://unix.stackexchange.com/a/701785

Still, new podman seems to have removed compose :(

Error: Fail run compose in "/tmp/tc_redpanda-single_01J46P1QZGHZBS3E86NSCFAMQW" because Compose command is unsupported for Podman 5.1.2

@ilaborie
Copy link
Collaborator

ilaborie commented Aug 2, 2024

Still, new podman seems to have removed compose :(

Podman does not support compose out of the box.
But you can use https://github.com/containers/podman-compose

@wiktor-k
Copy link
Contributor Author

wiktor-k commented Aug 2, 2024

Still, new podman seems to have removed compose :(

Podman does not support compose out of the box. But you can use https://github.com/containers/podman-compose

Thanks for explaining!

Btw it seems tests fail because of MSRV and new versions of crates (I was thinking about submitting a PR with deps updates too later).

@wiktor-k wiktor-k force-pushed the wiktor/prefix-shortname-images branch from bd998be to 30cf01c Compare August 5, 2024 09:31
@wiktor-k
Copy link
Contributor Author

wiktor-k commented Aug 5, 2024

Phew, okay, rebased on top of main. Thanks for the patience @ilaborie! 😅

@ilaborie ilaborie merged commit 9b4808f into wefoxplatform:main Aug 6, 2024
9 checks passed
@wiktor-k wiktor-k deleted the wiktor/prefix-shortname-images branch August 6, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants