Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump better_errors from 2.5.0 to 2.9.1 #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps better_errors from 2.5.0 to 2.9.1.

Release notes

Sourced from better_errors's releases.

v2.9.1

  • Fix setting editor with symbol #492

v2.9.0

  • Mention path in text response #487
  • Use Github Actions for CI #489
  • Exception Hints #302
  • Hide "live shell" hint after console has been used #490
  • Improve editor support for virtual environments #488
  • Fix "live shell" hint reappearing when frame changed #491

v2.8.3

  • Fix 'uninitialized constant BetterErrors::Middleware::VERSION' #480
  • Fix CSRF_TOKEN_COOKIE_NAME wrong reference to VERSION constant #481

v2.8.2

  • Fix path of CSRF Token cookie #478

v2.8.1

  • Show real cause of ActionView::Template::Error with Rails 6 #477
  • Add TruffleRuby to CI builds #473

v2.8.0

  • Support for Rails ActionableError #465
  • Allow editor links to work inside an iframe or with CSP that prohibits other protocols #440
  • Add CSRF protection to internal requests #474
  • Validate internal request method names #475

v2.7.1

  • Show location of error in ActionView template error #463

v2.7.0

v2.6.0

  • Specify older kramdown and i18n for older ruby versions #437
  • Fix NoMethodError when variables cannot be retrieved from the stack frame #430
  • Allow passing IPAddrs to allow_ip #444
  • Update CI Ruby to fix Travis CI failures #450

v2.5.1

Commits
  • fce143f Merge pull request #492 from srachner/fix-setting-editor-with-symbol
  • 1f65a70 Fix setting editor with symbol
  • afc1e3e Merge pull request #491 from BetterErrors/fix/hiding-hint-not-working-when-fr...
  • 9d7256b Fix "live shell" hint reappearing when frame changed
  • 66f2949 Merge pull request #488 from BetterErrors/feature/editor-support-docker
  • 123f9b3 Test invalid editor
  • 45915e6 Support for virtual and host paths
  • 6591cf9 Rename method and reorder
  • b95d3c3 Create instances of Editor
  • 5931137 Specs for Editor module
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Nov 6, 2020
@dependabot-preview
Copy link
Contributor Author

We've just been alerted that this update fixes a security vulnerability:

Sourced from The GitHub Security Advisory Database.

Older releases of better_errors open to Cross-Site Request Forgery attack

Impact

better_errors prior to 2.8.0 did not implement CSRF protection for its internal requests. It also did not enforce the correct "Content-Type" header for these requests, which allowed a cross-origin "simple request" to be made without CORS protection. These together left an application with better_errors enabled open to cross-origin attacks.

As a developer tool, better_errors documentation strongly recommends addition only to the development bundle group, so this vulnerability should only affect development environments. Please ensure that your project limits better_errors to the development group (or the non-Rails equivalent).

Patches

Starting with release 2.8.x, CSRF protection is enforced. It is recommended that you upgrade to the latest release, or minimally to "~> 2.8.3".

Workarounds

There are no known workarounds to mitigate the risk of using older releases of better_errors.

References

  • Chris Moberly provided an example attack that uses a vulnerability of webpack-dev-server in conjunction with Better Errors that will be published soon.
  • ... (truncated)

Affected versions: ["< 2.8.0"]

@dependabot-preview dependabot-preview bot changed the title Bump better_errors from 2.5.0 to 2.9.1 [Security] Bump better_errors from 2.5.0 to 2.9.1 Sep 7, 2021
@dependabot-preview dependabot-preview bot added the security Pull requests that address a security vulnerability label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants