Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoD 2021] Formatted .vscode files using prettier #19

Closed
wants to merge 4 commits into from
Closed

[GSoD 2021] Formatted .vscode files using prettier #19

wants to merge 4 commits into from

Conversation

iamrajiv
Copy link
Member

@iamrajiv iamrajiv commented Jul 10, 2021

Signed-off-by: Rajiv Ranjan Singh <[email protected]>
Copy link

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure refactoring

@huan
Copy link
Member

huan commented Sep 8, 2021

Hi @iamrajiv ,

Thanks for introducing the `prettier to our project!

After I learn about it, I think it would be great if we can have a prettier linter in our community.

Could you please read the https://prettier.io/docs/en/integrating-with-linters.html and propose a solution? For example, we can add the prettier linting plugin to @chatie/eslint-config, so that all the Wechaty community projects can be benefited from it.

@huan
Copy link
Member

huan commented Sep 16, 2021

I think what we need is a linter which will throw an error by following our config file, instead of a rewriter.

For this PR, it will be good to go after:

  1. Follow my review: always keep the trailing comma, and
  2. Make the CI green by fixing the code.

Thank you very much!

@huan
Copy link
Member

huan commented Sep 16, 2021

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants