Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csharp.yml #180

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update csharp.yml #180

wants to merge 3 commits into from

Conversation

Jesn
Copy link
Contributor

@Jesn Jesn commented May 17, 2022

csharp action workflow-> remove push to nuget job

action workflows remove  push to nuget
@huan
Copy link
Member

huan commented May 17, 2022

Could you please have a short explanation about this change?

Thank you very much!

@Jesn
Copy link
Contributor Author

Jesn commented May 18, 2022

csharp.yml 之前会build csharp/Wechaty.Grpc 解决方案生成nuget包,并推送到Nuget服务器,本次修改移除了Nuget包推送到Nuget服务器的这一步操作,只验证解决方案是否报异常

@huan
Copy link
Member

huan commented May 18, 2022

Thanks for the clarification!

According to our best practice of DevOps, I think it would be great if we could publish our package to the Nuget server after the CI passed.

However, this is a suggestion and you will make the final decision.

Should we merge this PR for now?

@huan
Copy link
Member

huan commented Jun 14, 2023

ping @Jesn

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants