-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file dialog in text editor example #215
Conversation
5086872
to
f049e5f
Compare
uniform quote usage naming closer to conventions add event only to relevant element
0d06ee1
to
765d4f2
Compare
765d4f2
to
6059a19
Compare
Since The cross browser solution preferres chromium based browsers and if none is available and another browsers like Firefox is used. A small workaround was implemented to ensure the editor still works in such a case. With the workaround, the input file dialog works just as it does with for chromium browsers. Just saving a file behaves a little different for Firefox. Pressing the save button will trigger the download function for the file that is edited. It works in regard to the Firefox user setting |
6ac629b
to
5bd69ed
Compare
5bd69ed
to
5a6df39
Compare
It's fine for two reasons, first, the majority of users are using one of the chromium based one. Second reason, Firefox may work fine when we implement TLS/SSL. |
Sorry for commenting on an already closed PR, but I just ran into the same issue. I intended on using the nativefiledialog c library to spawn an open-file-dialog which I wanted to trigger from the frontend. I got the same error message as in #213 . Is there a way to avoid the error without the need to access the file system directly through JS (because that is quite limiting in capabilities)? |
@mountfx Can you please open a new issue, share the logs, crash message, and the language/wrapper you are using, and the OS, this will help us to quickly identify the issue. |
Closes #213. This can be the equivalent for the C example to the go fix webui-dev/go-webui#13 (comment).
The fix in commit No. 1.
Commit No.2 includes a cleanup to the ui.js of the editor (mainly things a linter or formatter would complain about). E.g.