-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Create Universal application #2190
Conversation
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Yes.
@DiegoRBaquero is assigned and hasn't had any activity on this PR since April 5th. So @DiegoRBaquero is currently blocking this PR.
Hopefully tagging @DiegoRBaquero will help move this forward 😉. Really want to see this! |
Can you please resolve the conflicts? |
@DiegoRBaquero Not sure I'm gonna be able to do that since I'm not the PR author. @Teutates can you resolve the merge conflicts? |
@fishcharlie @DiegoRBaquero Does this do the trick? |
works fine here, i have successfully built webtorrent-desktop for arm64 macos |
Bumping @DiegoRBaquero |
If anyone is willing to run code from a random dude on the Internet until this PR gets merged and released, I’ve built the package with https://transfer.sh/xMRjmg/WebTorrent.zip @DiegoRBaquero @Teutates is there anything blocking this PR? |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Yes. It's still relevant. As @Teutates mentioned above: Bumping @DiegoRBaquero |
why this wasn't merged since the Autumn? |
@DiegoRBaquero latest merge conflicts removed. |
@DiegoRBaquero this PR has been open for over a year now. Any status updates? |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Yes, this is still relevant. cc @DiegoRBaquero |
I'm considering this project is no longer relevant to webtorrent, need to manually update a lot of dependencies plus webtorrent 2.x doesn't work with this client. apart from electron that is very Old |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Really disappointing that this was closed. @DiegoRBaquero can we get this reopened and merged? |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[ X ] Other, please explain: Adds arm64 arch to macOS build
What changes did you make? (Give an overview)
Add arm64 arch to macOS build to create a universal Intel/Apple Silicon app
Which issue (if any) does this pull request address?
#1907
Is there anything you'd like reviewers to focus on?
N/A