Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Create Universal application #2190

Closed
wants to merge 11 commits into from
Closed

Conversation

Teutates
Copy link

@Teutates Teutates commented Apr 5, 2022

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[ X ] Other, please explain: Adds arm64 arch to macOS build

What changes did you make? (Give an overview)

Add arm64 arch to macOS build to create a universal Intel/Apple Silicon app

Which issue (if any) does this pull request address?

#1907

Is there anything you'd like reviewers to focus on?

N/A

@welcome
Copy link

welcome bot commented Apr 5, 2022

🙌 Thanks for opening this pull request! You're awesome.

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Jun 5, 2022
@fishcharlie
Copy link

Is this still relevant?

Yes.

If so, what is blocking it?

@DiegoRBaquero is assigned and hasn't had any activity on this PR since April 5th. So @DiegoRBaquero is currently blocking this PR.

Is there anything you can do to help move it forward?

Hopefully tagging @DiegoRBaquero will help move this forward 😉.


Really want to see this!

@DiegoRBaquero
Copy link
Member

Can you please resolve the conflicts?

@fishcharlie
Copy link

@DiegoRBaquero Not sure I'm gonna be able to do that since I'm not the PR author.

@Teutates can you resolve the merge conflicts?

@github-actions github-actions bot removed the stale label Jun 8, 2022
@Teutates
Copy link
Author

Teutates commented Jul 2, 2022

@fishcharlie @DiegoRBaquero Does this do the trick?

@treeshateorcs
Copy link

works fine here, i have successfully built webtorrent-desktop for arm64 macos

@Teutates
Copy link
Author

Teutates commented Sep 2, 2022

Bumping @DiegoRBaquero

@tie
Copy link

tie commented Oct 10, 2022

If anyone is willing to run code from a random dude on the Internet until this PR gets merged and released, I’ve built the package with refs/pull/2190/merge checked out.

https://transfer.sh/xMRjmg/WebTorrent.zip

@DiegoRBaquero @Teutates is there anything blocking this PR?

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Dec 10, 2022
@fishcharlie
Copy link

Yes. It's still relevant. As @Teutates mentioned above: Bumping @DiegoRBaquero

@github-actions github-actions bot removed the stale label Dec 11, 2022
@ivan-zakharchuk
Copy link

why this wasn't merged since the Autumn?

@Teutates
Copy link
Author

@DiegoRBaquero latest merge conflicts removed.

@fishcharlie
Copy link

@DiegoRBaquero this PR has been open for over a year now. Any status updates?

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Jun 18, 2023
@tie
Copy link

tie commented Jun 20, 2023

Yes, this is still relevant. cc @DiegoRBaquero

@github-actions github-actions bot removed the stale label Jun 20, 2023
@farribeiro
Copy link

I'm considering this project is no longer relevant to webtorrent, need to manually update a lot of dependencies plus webtorrent 2.x doesn't work with this client. apart from electron that is very Old

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Aug 20, 2023
@github-actions github-actions bot closed this Aug 28, 2023
@fishcharlie
Copy link

Really disappointing that this was closed. @DiegoRBaquero can we get this reopened and merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants