test: use path.join to join path to browser

webrtcHacks · Apr 20, 2024 · 6cc02fd · 6cc02fd
1 parent 1ee2f65
commit 6cc02fd
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/test/karma.conf.js b/test/karma.conf.js
@@ -9,6 +9,7 @@
 'use strict';
 
 const os = require('os');
+const path = require('path');
 const puppeteerBrowsers = require('@puppeteer/browsers');
 
 async function download(browser, version, cacheDir, platform) {
@@ -20,11 +21,12 @@ async function download(browser, version, cacheDir, platform) {
  cacheDir,
  platform
  });
+ console.error(browser, version, platform, buildId);
  return buildId;
 }
 
 module.exports = async(config) => {
- const cacheDir = process.cwd() + '/browsers';
+ const cacheDir = path.join(process.cwd(), 'browsers');
  const platform = puppeteerBrowsers.detectBrowserPlatform();
 
  let browsers;
@@ -58,13 +60,13 @@ module.exports = async(config) => {
  '/Contents/MacOS/Safari Technology Preview';
  }
 
- if (browsers.includes('firefox') && !process.env.FIREFOX_BIN) {
+ if (browsers.includes('firefox')) {
  const buildId = await download('firefox', process.env.BVER || 'stable',
  cacheDir, platform);
  process.env.FIREFOX_BIN = puppeteerBrowsers
  .computeExecutablePath({browser: 'firefox', buildId, cacheDir, platform});
  }
- if (browsers.includes('chrome') && !process.env.CHROME_BIN) {
+ if (browsers.includes('chrome')) {
  const buildId = await download('chrome', process.env.BVER || 'stable',
  cacheDir, platform);
  process.env.CHROME_BIN = puppeteerBrowsers