Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save new workflow scope type preference #2099

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Save new workflow scope type preference #2099

merged 5 commits into from
Oct 3, 2024

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Oct 3, 2024 •
edited
Loading

Resolves #2091

Changes

Saves scope type chosen from "+ New Workflow" dropdown to local storage.

Manual testing

  1. Log in as crawler
  2. Go to "Crawling"
  3. Select scope type from "+ New Workflow" dropdown
  4. Refresh page. Verify scope type selection persists
  5. Change scope type. Refresh. Verify scope type selection persists
  6. Go back to "Crawling" and click "+ New Workflow". Verify last scope type is selected
  7. Close all browser tabs
  8. Log back in
  9. Repeat and verify step 6
  10. Log out and log back in
  11. Verify scope type selection is reset to "Single Page"

@SuaYoo SuaYoo force-pushed the frontend-new-workflow-preference branch from 5a9745d to 566db92 Compare October 3, 2024 01:52
ikreymer
ikreymer approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested from both crawl workflows dropdown and within new crawl workflow

@ikreymer ikreymer merged commit 22435dd into main Oct 3, 2024
2 checks passed
@ikreymer ikreymer deleted the frontend-new-workflow-preference branch October 3, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

@Shrinks99 Shrinks99 Awaiting requested review from Shrinks99

@emma-sg emma-sg Awaiting requested review from emma-sg

@tw4l tw4l Awaiting requested review from tw4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Save new workflow scope type preference
2 participants
@SuaYoo @ikreymer