Improved locking performance on .NET 9.0+ #685
Commits on Aug 15, 2024
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Fix to Debug Port of Public.API always being overwritten by servers.json
WebUI would not launch in Debug mode because the default servers.json file always overwrites the debug port values (9695) with release port (9696) when ServerConnectionManager.GetServerConnections() is called on line 142.
-
-
-
-
Created basic unit tests for the Loggy class in Certify.Shared.Core
Created this basic unit tests for Loggy as an easy entry point into writing MSTest C# unit tests for a simple wrapper class, increased unit test code coverage for Loggy.cs to 100% webprofusion/certify-general#7
-
-
Simplify SelectCAWithFailover based on GetAccountsWithRequiredCAFeatures
Filtering logic for SelectCAWithFailover() on line 323 is already handled in GetAccountsWithRequiredCAFeatures() on line 280 Change IP_SINGLE feature logic to match DOMAIN_SINGLE logic (line 252) Expanded unit testing scenarios in CAFailoverTests for RenewalManager Added in the start of a test for CAs with TnAuthList Code is commented out, as it requires addition setup info (A test CA auth token) to function properly Split up existing AccessControl unit test and added new tests The existing unit test for Access Control was testing too many things, so it was split into several tests, and new tests were added for testing methods such as GetSecurityPrinciple(), UpdateSecurityPrinciple(), and DeleteSecurityPrinciple(). Update fixing the Update() method for MemoryObjectStore The existing method did not correctly call TryUpdate() as it did not use the previous value of the key for comparison See https://learn.microsoft.com/en-us/dotnet/api/system.collections.concurrent.concurrentdictionary-2.tryupdate?view=net-7.0 Fixes for UpdateSecurityPrinciple and DeleteSecurityPrinciple failures The current logic for these methods to not report back if the data mutation methods fail, and assume they always succeed. Added test for AccessControl.UpdateSecurityPrinciplePassword() Added more negative testing for error cases of methods in AccessControl One if-logic branch of IsAuthorised() is still uncovered on line 174 of AccessControl Added TestInitialize Method to reduce duplication in AccessControlTests
-
-
-
-
-
-
-
Added Integration Tests for CertifyManager.ServerType partial class
Adds full line coverage for the file CertifyManager.ServerType.cs Will require changes once an Apache plugin is created
-
-
Refactored TestCertifyManagerGetACMEProvider, moved to integration tests
TestCertifyManagerGetACMEProvider now creates/destroys its own ACME account, and grabs the expected Acme Base URI from definition in CertificateAuthority.CoreCertificateAuthorities
-
-
-
-
Docker: update debug config and allow write to app settings for non-p…
…rivileged app user
-
-
-
-
-
-
-
Fixing file paths for tests running in Linux containers/envs
Fix loading Credential Manager in Linux containers/envs Fix loading Env strings on Linux containers/envs Fix when there is no existing ACME accounts in a container/env Initial implementation for managing certs on different OSs Changes for testing error message for bad Cert Store name on various OSs Improve error logging for Binding Match tests Changes for getting debug info on non-Windows systems Changes for making Linux and Windows Docker Images of Core Unit Tests Only the .NET 8.0 images are currently working as they should, there are some issues with the .NET 4.6.2 images for Windows and Linux Fix to generating debug info for non-Windows OSs Create common utility method to get Environment values in Account Tests Remove unneeded changes to Certify.Core.Tests.Unit.csproj Improve path strings for multiple OSs using Path.Combine() Changes to Linux Dockerfiles for Certify.Core.Tests.Unit Changes to enable using Step CA for CertifyManagerAccount unit tests Fix to BindingMatchTests for bad file path Windows docker changes More Windows Docker changes Fixes to compose files Documents for running the Certify Core Unit Tests in Docker Fix to formatting of Certify Core Unit Test Docker.md Cleanup linux_compose.yaml
-
-
-
First attempt adding testing Github Actions for Certify.Core.Tests.Unit
Fix to the .NET Version number needed to download SDK Changes for pulling dependencies, and splitting 8.0 into two workflows Change ref type for plugins dependency branch More changes to cloning dependencies in GitActions Fix path for cloning certify-internal repo Testing actions without internal repo clone Fixing relative placement of cloning paths for dependency repos Setting repos for "side by side" checkout https://github.com/actions/checkout#checkout-multiple-repos-side-by-side Fix paths on dotnet tool steps Disable .NET 4.6.2 Test Workflow until cause of test stalls is fixed Default pull step for cloning webprofusion/certify-plugins Add step to setup Step CLI on Windows Test Runner Add Github Actions step to pull step-ca docker image on Windows runner Add Github Actions step to pull step-ca docker image on Linux runner Fix Setup Step CLI GitHub Actions step for Windows runner Fix Setup Step CLI GitHub Actions step for Linux runner Refactor step-ca-win to be more like step-ca Linux image with env args Changes to CertifyManagerAccountTests for Windows GitHub Actions runner Fix to CertifyManagerAccountTests for Windows GitHub Actions runner Fixes mounting Docker volume Adding Step-CA and Step CLI dependencies to .NET 4.6.2 test GitHub flow Fix to CertifyManagerAccountTests for Windows GitHub Actions runner Debug Windows runner on GitHub for CertifyManagerAccountTests Fixes for running CertifyManagerAccountTests in Windows GitHub Runner Tweak to command for Setup Step CLI step in Windows GitHub Runner More Fixes for missing LE Accounts expected by Unit Tests Debug step for Step CLI setup in Windows GitHub Runner More fixes to running tests in GitLab Runners More debugging info for fixing GitLab Runners More debugging info for Step CLI step in GitLab Runners Tweak for adding Step CLI to Windows GitLab Runner PATH Another tweak for adding Step CLI to Windows GitLab Runner PATH Path update for Step CLI in Windows GitLab Runner More GitHub Runner Tweaks Add to Windows GitHub Path using GITHUB_PATH Finishing up adding Step CLI to PATH in Windows GitHub Runners Testing adding code coverage report to GitHub Actions markup output Update sticky pull request comment version in Linux GitHub Action Try using EnricoMi/publish-unit-test-result-action GitHub action Make coverage report without GitHub Action, using ReportGenerator CLI Debug output files to Testresults folder from dotnet test Further debugging of test results output files Fix path for cobertura coverage file in report generation Add Coverlet Collector Package at runtime of GitHub Action for coverage Specify working directory when adding Coverlet Collector package Add coverlet.collector through project dependencies rather than CLI Changes to fix loading Coverlet Collector without running dotnet publish Remove coverage directory debug step Remove coverage directory debug step on Linux Tweaks to fix PR GitHub Actions Test jobs for Certify More tweaks to fix PR GitHub Actions Test jobs for Certify Edit to generate HTML Test Results Artifact Add .NET Core 3.1.x to GitHub Actions for Trx-To-HTML Tool Generate HTML Test Results report with built-in Logger Attempting to output CLI reports to Markdown in GITHUB_STEP_SUMMARY Fix for generating Test Results Markdown Tweaks to generating Markdown reports for Windows Runners Change Markup Report Titles and Display Order Add Folder parameter to Test Results Generation Trying to suppress build warnings from being added to annotations Trying out dorny/test-reporter action on Linux runner Fix to dorny/test-reporter step for Linux GitHub Actions runner Trying out Tyrrrz/GitHubActionsTestLogger on Linux Runner Fix for trying out Tyrrrz/GitHubActionsTestLogger on Linux Runner Another Fix for Tyrrrz/GitHubActionsTestLogger on Linux Runner Debug GITHUB_WORKSPACE value for Tyrrrz/GitHubActionsTestLogger Debug Tyrrrz/GitHubActionsTestLogger source link generation More debugging Tyrrrz/GitHubActionsTestLogger source link generation More debugging Tyrrrz/GitHubActionsTestLogger source link generation Cleanup GitHub Action Workflow YAML for .NET Core 8.0 on Windows & Linux Fix GitHub Action Workflow YAML for .NET Core 8.0 on Windows & Linux Tweak to GitHub Action Workflow YAML for .NET Core 8.0 on Windows Fix paths in dotnet test step for Windows .NET Core Action Debug Windows .NET Core 8.0 Test Result Generation Fix Windows .NET Core 8.0 Test Result Generation Separate Test Run and Test Results step for Windows Runner .NET Core 8.0 Restore working directory info to Windows test run step More YAML action updates for Linux and Windows .NET Core 8.0 runners More tweaks to GitHub Actions for test runs on Windows and Linux Fix to running tests in Linux GitHub Action Fix to path to Coverlet on Linux test runner Lint cleanup for ChallengeConfigMatchTests Certify Core Unit Tests Refactors to speed up execution of CertifyManagerAccountTests Unit Tests Test out using Linux Docker containers on Windows GitHub Action Runner Debug Docker location in GitHub Actions Windows Runner More debugging DockerCli.exe location in GitHub Actions Windows Runner More debugging DockerCli.exe location in GitHub Actions Windows Runner More debugging DockerCli.exe location in GitHub Actions Windows Runner More debugging DockerCli.exe location in GitHub Actions Windows Runner Simplify Docker Info command output in CertifyManagerAccountTests More debugging DockerCli.exe location in GitHub Actions Windows Runner More debugging DockerCli.exe location in GitHub Actions Windows Runner More debugging DockerCli.exe location in GitHub Actions Windows Runner More debugging DockerCli.exe location in GitHub Actions Windows Runner More debugging DockerCli.exe location in GitHub Actions Windows Runner Restore using Windows Docker Image for Windows Runners in GitHub Actions Test Caching NuGet Dependencies for Linux and Windows GitHub Actions Remove blank Constructor methods to enable debugging in .NET 4.6.2 Fix Unit/Integration tests stalling in 4.6.2 when using CertifyManager Re-enable Windows 4.6.2 Certify Core Unit Test GitHub Action Workflow Fix to Windows .NET 4.6.2 test run GitHub Action Workflow Disable Coverage Report for .NET 4.6.2 until issue can be determined Fix Test Result generation for Windows .NET 4.6.2 runs Fix for enabling Coverage Report on 4.6.2 Windows Test Runs Another fix for enabling Coverage Report on 4.6.2 Windows Test Runs Script fix for enabling Coverage Report on 4.6.2 Windows Test Runs YAML fixes for caching NuGet dependencies Fixes to Windows NuGet dependency caching Disable archiving Test Artifacts on all GitHub Actions Test Jobs More tweaks to NuGet Dependency caching in GitHub Actions Simplify Code Coverage Generation for 4.6.2 runs Simplify testing commands for GitHub Actions using .runsettings files Further fixes to GitHub Actions report generation Fix Linux Test Results Directory to match value from ${{ runner.os }} Filter unused DataStore Plugins from Unit Test Reports with Coverlet Add basic Unit Test for Certify.Service so it shows on 4.6.2 coverage Expand tests for Certify.Service Additional Certify.Service tests Update 4_6_2_Core_Unit_Tests_Win.yaml add conditions for plugin checkout to match current release and development branch names Update 8_0_Core_Unit_Tests_Linux.yaml Update conditional for plugin repo checkout Update 8_0_Core_Unit_Tests_Win.yaml Update conditional for plugin repo checkout
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Anvil: chain build - fallback to skipping chain build if no issuers k…
…nown Anvil: add logging directly to item log if chain build errors occur
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
WIP: multi instance hub Package updates WIP: managed instances WIP - multi instance WIP: management hub - get and update remote items
-
-
-
-
-
-
-
-
Package updates, OpenAPI build fix, begin using ms logging interface
-
-
-
-
-
-
-
Test: fix primary domain test config
Test: fix version check test Update test dotnet targets
-
-
-
-
-
-
Add request throttling to http logging handler
Update acme directory tests
-
-
Update DotNetCore_Unit_Tests_Win.yaml
Update DotNetCore_Unit_Tests_Linux.yaml Update DotNetCore_Unit_Tests_Win.yaml Update DotNetCore_Unit_Tests_Linux.yaml Update DotNetCore_Unit_Tests_Linux.yaml Update DotNetCore_Unit_Tests_Linux.yaml
-
-
-
-
-
-
Commits on Aug 18, 2024
Commits on Aug 19, 2024
Commits on Sep 1, 2024
Commits on Sep 4, 2024
-
Package updates Package updates Package updates Package updates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.