-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#798 exclude built-in cypress reporters from dependency check #803
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { nxE2EPreset } from '@nrwl/cypress/plugins/cypress-preset'; | ||
import { defineConfig } from 'cypress'; | ||
|
||
const cypressJsonConfig = {}; | ||
|
||
export default defineConfig({ | ||
reporter: "junit", | ||
e2e: { | ||
...nxE2EPreset(__dirname, {}), | ||
...cypressJsonConfig, | ||
}, | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { faker } from '@faker-js/faker'; | ||
|
||
function login() { | ||
return faker; | ||
} | ||
|
||
Cypress.Commands.add('login', login); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same, no need for unnecessary files in fixture folders (less bloat is better long-term). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import '@testing-library/cypress/add-commands'; | ||
import './commands'; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"name": "@fixtures/cypress", | ||
duncan-thacker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"devDependencies": { | ||
"cypress": "*", | ||
"cypress-multi-reporters": "*", | ||
"mocha-junit-reporter": "*", | ||
"mochawesome": "*" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"reporterEnabled": "mochawesome, mocha-junit-reporter , @testing-library/my-fake-reporter" | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { test } from 'bun:test'; | ||
import assert from 'node:assert/strict'; | ||
import { main } from '../../src/index.js'; | ||
import { resolve } from '../../src/util/path.js'; | ||
import baseArguments from '../helpers/baseArguments.js'; | ||
|
||
const cwd = resolve('fixtures/plugins/cypress-multi-reporter'); | ||
|
||
test('Exclude built-in cypress reporters from dependency checks', async () => { | ||
const { issues, counters } = await main({ | ||
...baseArguments, | ||
cwd, | ||
}); | ||
|
||
assert(!issues.unlisted['cypress.config.ts']['junit']); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you please revert/add the counters, they're essential to assert there are no other issues. |
||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's a copy and we're already testing
e2e
like this the same way than we could just remove the duplication.