Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest): support default coverage provider #192

Merged
merged 2 commits into from
Aug 5, 2023
Merged

fix(vitest): support default coverage provider #192

merged 2 commits into from
Aug 5, 2023

Conversation

risu729
Copy link
Contributor

@risu729 risu729 commented Aug 5, 2023

Vitest has a default coverage provider, v8, but knip detects it as an unused dependency.
We can safely assume the user uses Vitest's coverage if the config file contains the coverage field, so this PR uses v8 as the default provider if provider is not set.

https://vitest.dev/guide/coverage.html#coverage-providers

@webpro
Copy link
Collaborator

webpro commented Aug 5, 2023

Thanks @risu729! Any chance you could add a (something to an existing) test?

@risu729
Copy link
Contributor Author

risu729 commented Aug 5, 2023

Sure! I added a test now.

@webpro webpro merged commit c321a9c into webpro-nl:main Aug 5, 2023
9 checks passed
@webpro
Copy link
Collaborator

webpro commented Aug 5, 2023

🚀 This pull request is included in v2.19.0. See Release 2.19.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants