#798 exclude built-in cypress reporters from dependency check #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test case is pretty much a direct copy of the |
webpro
reviewed
Oct 4, 2024
| reporter: "junit", | ||
| e2e: { | ||
| ...nxE2EPreset(__dirname, {}), | ||
| ...cypressJsonConfig, |
There was a problem hiding this comment.
If it's a copy and we're already testing e2e like this the same way than we could just remove the duplication.
| return faker; | ||
| } | ||
|
|
||
| Cypress.Commands.add('login', login); |
There was a problem hiding this comment.
Same, no need for unnecessary files in fixture folders (less bloat is better long-term).
packages/knip/fixtures/plugins/cypress-builtin-reporter/package.json
Outdated
Show resolved
Hide resolved
commit: |
…e.json Co-authored-by: Lars Kappert <[email protected]>
webpro
reviewed
Oct 5, 2024
| cwd, | ||
| }); | ||
|
|
||
| assert(!issues.unlisted['cypress.config.ts']['junit']); |
There was a problem hiding this comment.
Could you please revert/add the counters, they're essential to assert there are no other issues.
|
Is there still interest to wrap this one up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #798
Filters out built-in dependencies when checking Cypress reporter packages