(TypeScript plugin): Add references path of tsconfig to config (#816)

webpro-nl · Oct 28, 2024 · bff0977 · bff0977
1 parent 366acdc
commit bff0977
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/packages/knip/fixtures/plugins/typescript/package.json b/packages/knip/fixtures/plugins/typescript/package.json
@@ -10,6 +10,7 @@
   "devDependencies": {
     "@tsconfig/node16": "*",
     "@tsconfig/node20": "*",
+    "@tsconfig/node22": "*",
     "typescript": "*"
   }
 }
diff --git a/packages/knip/fixtures/plugins/typescript/tsconfig.app.json b/packages/knip/fixtures/plugins/typescript/tsconfig.app.json
@@ -0,0 +1,4 @@
+{
+    "extends": "@tsconfig/node22/tsconfig.json",
+    "compilerOptions": {}
+}
diff --git a/packages/knip/fixtures/plugins/typescript/tsconfig.json b/packages/knip/fixtures/plugins/typescript/tsconfig.json
@@ -16,5 +16,10 @@
         "tag": "gql"
       },
     ]
-  }
+  },
+  "references": [
+    {
+      "path": "./tsconfig.app.json"
+    },
+  ]
 }
diff --git a/packages/knip/src/plugins/typescript/index.ts b/packages/knip/src/plugins/typescript/index.ts
@@ -25,7 +25,12 @@ const resolveConfig: ResolveConfig<TsConfigJson> = async (localConfig, options)
     ? [localConfig.extends].flat().map(specifier => toConfig('typescript', specifier, options.configFilePath))
     : [];
 
-  if (!(compilerOptions && localConfig)) return extend;
+  const references =
+    localConfig.references
+      ?.filter(reference => reference.path.endsWith('.json'))
+      .map(reference => toConfig('typescript', reference.path, options.configFilePath)) ?? [];
+
+  if (!(compilerOptions && localConfig)) return compact([...extend, ...references]);
 
   const jsx = (compilerOptions?.jsxImportSource ? [compilerOptions.jsxImportSource] : []).map(toProductionDependency);
 
@@ -35,7 +40,7 @@ const resolveConfig: ResolveConfig<TsConfigJson> = async (localConfig, options)
     : [];
   const importHelpers = compilerOptions?.importHelpers ? ['tslib'] : [];
 
-  return compact([...extend, ...[...types, ...plugins, ...importHelpers].map(toDeferResolve), ...jsx]);
+  return compact([...extend, ...references, ...[...types, ...plugins, ...importHelpers].map(toDeferResolve), ...jsx]);
 };
 
 const args = {