-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve error and warning messages in overlay #4087
base: master
Are you sure you want to change the base?
Conversation
b0d7246
to
478b963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's add more tests
Codecov Report
@@ Coverage Diff @@
## master #4087 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 16 16
Lines 1593 1593
Branches 596 596
=======================================
Hits 1470 1470
Misses 114 114
Partials 9 9 Continue to review full report at Codecov.
|
yes, WIP on tests |
478b963
to
b78547a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add more tests?
Yes, can you suggest some test cases? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create errors in custom plugin with module name, message, file and etc, will be great to have even real problems from webpack, just create situation when webpack throws them
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Refers #3689
improve error and warning messages in overlay.
Breaking Changes
None
Additional Info
No