-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): provide option for disabling console warn messages #321
base: master
Are you sure you want to change the base?
Conversation
add noWarn client parameter resolves webpack-contrib#319
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 87.5% 87.17% -0.33%
==========================================
Files 3 3
Lines 232 234 +2
Branches 65 66 +1
==========================================
+ Hits 203 204 +1
- Misses 29 30 +1
Continue to review full report at Codecov.
|
Unfortunately, the internal |
Ah, ok didn't realize that. I'll take a closer look. |
@jgraniero Are you still working on this? We have the exact same use case you originally reported. Thank you for trying to add |
Yea, been super busy so haven't had the time to revisit this yet, but I'm trying! |
No pressure. Thank you for looking into this. |
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 87.50% 87.17% -0.33%
==========================================
Files 3 3
Lines 232 234 +2
Branches 65 66 +1
==========================================
+ Hits 203 204 +1
- Misses 29 30 +1
Continue to review full report at Codecov.
|
add noWarn client parameter
resolves #319
This PR contains a:
Motivation / Use-Case
Add support for disabling console.warn messages on the client.
Resolves #319
Breaking Changes
Additional Info