Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): provide option for disabling console warn messages #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgraniero
Copy link

add noWarn client parameter

resolves #319

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add support for disabling console.warn messages on the client.

Resolves #319

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Jul 10, 2018

Codecov Report

Merging #321 into master will decrease coverage by 0.32%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage    87.5%   87.17%   -0.33%     
==========================================
  Files           3        3              
  Lines         232      234       +2     
  Branches       65       66       +1     
==========================================
+ Hits          203      204       +1     
- Misses         29       30       +1
Impacted Files Coverage Δ
client.js 85.18% <50%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d46df6...cc76b8e. Read the comment docs.

@glenjamin
Copy link
Collaborator

Unfortunately, the internal warn variable is poorly named, setting it to true will also hide error logging.

@jgraniero
Copy link
Author

Ah, ok didn't realize that. I'll take a closer look.

@donaldpipowitch
Copy link

@jgraniero Are you still working on this? We have the exact same use case you originally reported. Thank you for trying to add warningsFilter support ❤️

@jgraniero
Copy link
Author

Yea, been super busy so haven't had the time to revisit this yet, but I'm trying!

@donaldpipowitch
Copy link

No pressure. Thank you for looking into this.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #321 into master will decrease coverage by 0.32%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   87.50%   87.17%   -0.33%     
==========================================
  Files           3        3              
  Lines         232      234       +2     
  Branches       65       66       +1     
==========================================
+ Hits          203      204       +1     
- Misses         29       30       +1     
Impacted Files Coverage Δ
client.js 85.18% <50.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d46df6...cc76b8e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress / filter console warning messages
3 participants