-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch from fast-glob to tinyglobby #791
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 90.55% 91.48% +0.92%
==========================================
Files 2 2
Lines 413 411 -2
Branches 120 119 -1
==========================================
+ Hits 374 376 +2
+ Misses 38 34 -4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You look good, have you tried to measure their performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some checks and got:
fast-glob x 15.46 ops/sec ±7.09% (47 runs sampled)
tinyglobby x 13.85 ops/sec ±4.45% (69 runs sampled)
Fastest is fast-glob
It seems that using it may cause performance issues.
@alexander-akait can you share the benchmark you ran? The only thing I'm switching here at the moment is which I would think that this method should be able to be run many orders of magnitude faster than that and any performance difference would just be noise in the overall performance of |
@benmccann Oh, I see, I just compared the speed of work between |
I thought I would break up the work to make things more reviewable and lower risk. This PR switches out all usage of fast-glob for tinyglobby, which I think we could merge here and then I could follow up with another PR to switch out globby for tinyglobby as well. If you're really worried about performance I could wait until the next tinyglobby release to do the second half as they're currently working to make sure tinyglobby is always faster than alternatives in SuperchupuDev/tinyglobby#76 |
@benmccann let's put all in one pr place, I don't think there will be many of them |
Okay. I'll close this for the time being then |
@benmccann We can keep open, no problems |
This PR contains a:
Motivation / Use-Case
Ref #788
Breaking Changes
None
Additional Info