Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 20.0.0.0beta1 #21

Merged
merged 18 commits into from
Dec 25, 2023
Merged

Update to 20.0.0.0beta1 #21

merged 18 commits into from
Dec 25, 2023

Conversation

liamharper2453
Copy link
Contributor

No description provided.

@tuxuser
Copy link
Member

tuxuser commented Dec 25, 2023

Thanks, good job!

Please reintroduce

      - uses: marvinpinto/action-automatic-releases@latest
        if: "github.ref == 'refs/heads/master'"
        with:
          repo_token: "${{ secrets.GITHUB_TOKEN }}"
          automatic_release_tag: latest
          prerelease: true
          title: "Development Build"
          files: |
            ${{github.workspace}}/*.ipk
            ${{github.workspace}}/org.webosbrew.hyperhdr.loader.manifest.json
      - uses: marvinpinto/action-automatic-releases@latest
        if: "startsWith(github.ref, 'refs/tags/v')"
        with:
          repo_token: "${{ secrets.GITHUB_TOKEN }}"
          prerelease: false
          title: ${{ github.ref_name }}
          files: |
            ${{github.workspace}}/*.ipk
            ${{github.workspace}}/org.webosbrew.hyperhdr.loader.manifest.json

then its good to merge

Actually - lemme do that really quick

@tuxuser tuxuser reopened this Dec 25, 2023
@liamharper2453
Copy link
Contributor Author

liamharper2453 commented Dec 25, 2023

Thanks, good job!

Please reintroduce

      - uses: marvinpinto/action-automatic-releases@latest
        if: "github.ref == 'refs/heads/master'"
        with:
          repo_token: "${{ secrets.GITHUB_TOKEN }}"
          automatic_release_tag: latest
          prerelease: true
          title: "Development Build"
          files: |
            ${{github.workspace}}/*.ipk
            ${{github.workspace}}/org.webosbrew.hyperhdr.loader.manifest.json
      - uses: marvinpinto/action-automatic-releases@latest
        if: "startsWith(github.ref, 'refs/tags/v')"
        with:
          repo_token: "${{ secrets.GITHUB_TOKEN }}"
          prerelease: false
          title: ${{ github.ref_name }}
          files: |
            ${{github.workspace}}/*.ipk
            ${{github.workspace}}/org.webosbrew.hyperhdr.loader.manifest.json

then its good to merge

Actually - lemme do that really quick

Ah yeah sorry I turned that off for testing my fork and didn't put it back in.

Do you think the removal of the flatc/flathash stuff is ok? They didn't seem to be in the HyperHDR build anymore hence why I took it out. But wasn't sure whether it was genuinely removed or I made a mistake. I did see a change around flatc/flathash for the build in the most recent HyperHDR commit (awawa-dev/HyperHDR@558c7e0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR635)

@tuxuser
Copy link
Member

tuxuser commented Dec 25, 2023

Do you think the removal of the flatc/flathash stuff is ok? They didn't seem to be in the HyperHDR build anymore hence why I took it out. But wasn't sure whether it was genuinely removed or I made a mistake. I did see a change around flatc/flathash for the build in the most recent HyperHDR commit (awawa-dev/HyperHDR@558c7e0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR635)

Looks like only flathash got removed, lets try to keep flatc if possible.. we will see soon

@awawa-dev
Copy link

Currently, if cross-compiling is detected, HyperHDR will use the flatbuffers from its submodule, will build the flatc compiler in the host environment and precompile the HyperHDR flatbuffer templates. Finally, they will be cross-compiled at a later stage using the same version of the flatbuffers from the submodule. Therefore, the host does not need to have its own flat buffers installed anymore.

@tuxuser
Copy link
Member

tuxuser commented Dec 25, 2023

Currently, if cross-compiling is detected, HyperHDR will use the flatbuffers from its submodule, will build the flatc compiler in the host environment and precompile the HyperHDR flatbuffer templates. Finally, they will be cross-compiled at a later stage using the same version of the flatbuffers from the submodule. Therefore, the host does not need to have its own flat buffers installed anymore.

Thanks for the insight!

@tuxuser tuxuser merged commit 343c73b into webosbrew:master Dec 25, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants