Fix scoping of context for mutations #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In webonyx#1385 we introduced the `ScopedContext` interface. When implemented on the Context, it would clone the context down to it's children. This works great for queries. But mutations are executed serially. I forgot to call `maybeScopeContext` there. This fixes the problem, and adds a test to guard it.it would clone the context down to it's children.
|
@spawnia This one is ready for review, when you have time. |
|
@spawnia You are probably busy. Do you have time for a review? Or is there anybody else that can do it? |
spawnia
approved these changes
Jun 10, 2024
|
Thanks, released with https://github.com/webonyx/graphql-php/releases/tag/v15.11.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1385 we introduced the
ScopedContextinterface. When implemented on the Context, it would clone the context down to it's children.This works great for queries. But mutations are executed serially. I forgot to call
maybeScopeContextthere.This fixes the problem, and adds a test to guard it.it would clone the context down to it's children.