fix: build client schema have custom scalar value mixed type #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
reviewed
Mar 10, 2024
vuongxuongminh
force-pushed
the
fix-build-client-schema-have-custom-scalar-value-mixed-type
branch
from
b29752e to
850393a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the serialize function of scalar type made by
GraphQL\Utils\BuildClientSchemaclass will cast value to string but it should return raw value instead for consistent withGraphQL\Utils\BuildSchemaand in GraphQL spec not have any notes said value of scalar types must be string https://graphql.org/learn/schema/#scalar-typesThis PR to solve the problem above