Correctly print deprecated argument with default value #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today I deprecated an argument with a default value and noticed that the schema was printed wrong:
```graphql
type Query {
singleField(id: ID @deprecated(reason: "this is deprecated") = 123): Int
}
```
The `@deprecated` directive should be put after the `= 123` default value.
ruudk
force-pushed
the
fix-deprecated-arg-default-value
branch
from
0e6c5e1 to
09ef235
Compare
|
@spawnia Ready for review, whenever you have time 💙 |
spawnia
approved these changes
Dec 5, 2023
|
Good catch, also seems like a very natural progression to have this combination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I deprecated an argument with a default value and noticed that the schema was printed wrong:
The
@deprecateddirective should be put after the= 123default value.