Specify summarization, destruction, and options #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is most of the remaining normative text for the summarizer API.
tomayac
reviewed
Nov 27, 2024
tomayac
reviewed
Nov 27, 2024
tomayac
reviewed
Nov 27, 2024
tomayac
reviewed
Nov 27, 2024
tomayac
reviewed
Nov 27, 2024
gjc13
reviewed
Dec 3, 2024
| <th>{{DOMException}} [=DOMException/name=] | ||
| <th>Scenarios | ||
| <tbody> | ||
| <tr> |
There was a problem hiding this comment.
Chromium is currently reporting InvalidStateError if the backend session is destroyed.
There was a problem hiding this comment.
How can the backend session be destroyed? Is it via the destroy() method or the AbortSignal? Then it should be an AbortError. Or is there some other possibility?
There was a problem hiding this comment.
It is caused by the backend aborting itself. Maybe we'd like to have another error type for backend failures or simply use UnknownError instead?
There was a problem hiding this comment.
Do you know why the backend would abort itself? Like, how would I trigger that as a user or developer?
But yes, I think UnknownError might be best for such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most of the remaining normative text for the summarizer API.
Preview | Diff