Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a section for updating an existing operation #705

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add a section for updating an existing operation #705

merged 1 commit into from
Jun 13, 2024

Conversation

huningxin
Copy link
Contributor

This PR addresses an open from @a-sully in discussion thread: #695 (comment)

@fdwr @inexorabletash @anssiko , PTAL.

@huningxin huningxin mentioned this pull request Jun 11, 2024
Draft
anssiko
anssiko approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There may be nuances in what is considered updating (versus adding a new and removing/deprecating), but this is a good starting point. We can adjust these guidelines as we learn more on this topic.

inexorabletash
inexorabletash approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huningxin huningxin merged commit c00560f into webmachinelearning:main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

@inexorabletash inexorabletash inexorabletash approved these changes

@anssiko anssiko anssiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huningxin @anssiko @inexorabletash @fdwr