Remove MLCommandEncoder #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sully
commented
Jan 31, 2024
|
To be coordinated with #531 |
huningxin
reviewed
Feb 4, 2024
a-sully
force-pushed
the
remove-mlcommandencoder
branch
from
11314e8 to
ee83591
Compare
a-sully
added a commit
to a-sully/webnn
that referenced
this pull request
Feb 4, 2024
Follow-up to webmachinelearning#546. MLBufferResourceView is not relevant without MLCommandEncoder
|
Thanks for the review @huningxin! @wchao1115 is also listed as a reviewer. Please take a look? Feel free to merge this PR if it looks good to you, since I don't seem to have the ability to merge it myself. Thanks! |
|
@wchao1115, let us know if you'd like to discuss this removal on our upcoming WG meeting. We should make a decision on this before we branch for our next spec release milestone. (FYI @a-sully, @wchao1115 is the original author of the proposal. I'd expect to see +1 from him.) |
a-sully
added a commit
to a-sully/webnn
that referenced
this pull request
Feb 6, 2024
Follow-up to webmachinelearning#546. MLBufferResourceView is not relevant without MLCommandEncoder
a-sully
added a commit
to a-sully/webnn
that referenced
this pull request
Feb 8, 2024
Follow-up to webmachinelearning#546. MLBufferResourceView is not relevant without MLCommandEncoder
a-sully
force-pushed
the
remove-mlcommandencoder
branch
from
ee83591 to
2bf3bd7
Compare
wchao1115
approved these changes
Feb 8, 2024
|
Thanks for the review, @wchao1115! I don't have write access to the repo, so I can't merge the PR. Would you mind pressing the button? :) |
github-actions bot
added a commit
that referenced
this pull request
Feb 8, 2024
SHA: 5c94a45 Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
anssiko
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Follow-up to #546. MLBufferResourceView is not relevant without MLCommandEncoder * remove "creation method" table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #528
Preview | Diff