Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document coding conventions and best practices for spec maintainers #525

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

inexorabletash
Copy link
Member

As suggested by @wchao1115 in #499 and #518, create a doc capturing past WG disscussions in the telecons, issues, and PRs, so that we can be consistent going forward. I'm reasonably sure I didn't capture everything, and I tried not to repeat the contents of Infra too much, but this captures most of the recent discussions I've been involved in. But it's a start!

I'd encourage the editors to edit this PR directly with any suggestions.

Copy link
Collaborator

@wchao1115 wchao1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @inexorabletash for this useful guidance and spec writing conventions. It looks good to me. @huningxin

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @inexorabletash for this contribution.

SpecCodingConventions.md Outdated Show resolved Hide resolved
As suggested by @wchao1115 in webmachinelearning#499 and webmachinelearning#518, create a doc capturing
past WG disscussions in the telecons, issues, and PRs, so that we can
be consistent going forward.
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, this is very useful. Thanks @inexorabletash !

@anssiko
Copy link
Member

anssiko commented Jan 24, 2024

I'm pleased to merge this PR that makes the editors' and other spec contributors' lives so much easier.

Thanks @inexorabletash! I assume you're already thinking of upstreaming the novel parts of this contribution to Bikeshed docs. These magic spells need to be shared with the entire community using Bikeshed so other spec efforts can benefit too. Good quality docs are so important for a tool such as Bikeshed. There's at least 3 resources I know of that cover this topic, and having guidelines synthesized in this fashion is so helpful. Maybe there's already an effort to unify the more generic docs.

@anssiko anssiko merged commit fa91851 into webmachinelearning:main Jan 24, 2024
2 checks passed
@inexorabletash inexorabletash deleted the coding-conventions branch January 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants