Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording change: New up a specific type, rather than just object #512

Merged

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Jan 17, 2024

In algorithms that mint MLActivations and MLOperands, construct the actual type not a generic "object". Also, use Infra wording around optional paramters to those algorithms.

For #450


Preview | Diff

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this strict improvement.

In algorithms that mint MLActivations and MLOperands, construct
the actual type not a generic "object". Also, use Infra wording
around optional paramters to those algorithms.

For webmachinelearning#450
@inexorabletash
Copy link
Member Author

Rebased - Preview | Diff now available.

@wchao1115 wchao1115 merged commit 83262c6 into webmachinelearning:main Jan 20, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 20, 2024
SHA: 83262c6
Reason: push, by wchao1115

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the wording-new-objects branch January 21, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants