Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNotepad: Add custom syntax highlighting, editor configuration #259

Merged

Conversation

inexorabletash
Copy link
Member

This introduces a basic declarative syntax highlighter via Monarch (https://microsoft.github.io/monaco-editor/monarch.html). The parsing isn't perfect, and there could be some deduplication in nnotepad.js but this is an improvement over using the markdown highlighter.

It also provides a language configuration to control bracket pairing and auto-closing, and auto-complete of MLGraphBuilder methods.

Fixes #256

This introduces a basic declarative syntax highlighter via Monarch
(https://microsoft.github.io/monaco-editor/monarch.html). The parsing
isn't perfect, and there could be some deduplication in nnotepad.js
but this is an improvement over using the markdown highlighter.

It also provides a language configuration to control bracket pairing
and auto-closing, and auto-complete of MLGraphBuilder methods.

Fixes webmachinelearning#256
@inexorabletash
Copy link
Member Author

@Honry and @ibelem - can you please review?

Copy link
Collaborator

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huningxin huningxin merged commit 70f6eb3 into webmachinelearning:master Jun 26, 2024
3 checks passed
@inexorabletash inexorabletash deleted the nnotepad-monarch branch June 26, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NNotepad] Add custom language grammar for Monaco editor
3 participants