-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNotepad: UI update #249
NNotepad: UI update #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change from "Nnodepad" to "NNotepad"? I cannot tell that from the diff.
@huningxin There was the typo in the svg logo, changed the text from "NNodepad" to "NNotepad" now, please refer to the updated new screen shot as attached. |
The UI update looks good to me. I'll defer to @inexorabletash for decision. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Some nitpicks, some requests.
Also, I'm seeing lots of console spam, e.g.:
- Uncaught SyntaxError: Unexpected token
<
- Error: Unexpected usage at _EditorSimpleWorker.loadForeignModule
It's possible I've got things set up incorrectly locally, but I don't think those are coming from my code.
@inexorabletash @huningxin @anssiko Thanks for the review and feedback, removed monaco-editor and vite-plugin-monaco-editor npm packages, and fixed issues captured by @inexorabletash. PTAL. |
Thanks - fixes look good. I appreciate the effort to make the simple HTTP server work! It's unfortunate to have to have a copy of the monaco editor in the source tree - is there any way to pull that in via npm to ease maintenance? I'm on vacation this week so I'll give a quick LGTM to unblock. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@inexorabletash Wishing you a fantastic break! The new commit removed monaco editor local codes from source tree, use the js files from CDN https://cdn.jsdelivr.net/npm/[email protected]/ instead. @huningxin @anssiko PTAL Verify it worked via Verify it worked via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggested change, but overall LGTM.
Thank you so much for taking this on!
@inexorabletash Thank you, added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Updated UI with following changes:
@inexorabletash @huningxin @Honry Please take a look and let me know if it's acceptable or not.