Add NNotepad sample #243
Merged
Add NNotepad sample #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not yet linked from the main README or index page as there is significant integration/cleanup work to do. But it is useful as-is for WebNN implementers. A bespoke test harness is included. Documentation visible in the sample is generated from the README.md (run `make` to update).
|
@huningxin can you take a look, or recommend other reviewers? |
huningxin
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
LGTM! Thanks @inexorabletash , I like your demo so much, I can't wait for trying it.
Honry
reviewed
Jun 6, 2024
| * Consider incorporating [WebNN Polyfill](https://github.com/webmachinelearning/webnn-polyfill). | ||
| * Make input/output areas resizable. | ||
| * Add to `../README.md` once we're happy with it. | ||
|
|
There was a problem hiding this comment.
- Style to match rest of webnn-samples.
- Consider incorporating WebNN Polyfill.
I can take these two TODOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not yet linked from the main README or index page as there is significant integration/cleanup work to do. But it is useful as-is for WebNN implementers.
A bespoke test harness is included. Documentation visible in the sample is generated from the README.md (run
maketo update).