Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for DML backend #292

Closed
wants to merge 1 commit into from

Conversation

mingmingtasd
Copy link
Collaborator

No description provided.

@mingmingtasd
Copy link
Collaborator Author

Will failed to build for main branch because main branch has removed files such as BackendDML.cpp under dml. So I suggest adding these CI after merging #287. WDYT? @BruceDai @fujunwei

@fujunwei
Copy link
Collaborator

Could you please check in the instance.cpp first, so that the main branch can pass the CI?

@mingmingtasd
Copy link
Collaborator Author

Could you please check in the instance.cpp first, so that the main branch can pass the CI?

Do you mean merge the change in instance firstly? @fujunwei

@mingmingtasd
Copy link
Collaborator Author

PTAL, thanks! @fujunwei @BruceDai
The failure seems caused by getting baseline for regression check, since there is no real implementation to support test cases, the failure should be expected, right? If so, can we merge it? Then I think the next PR will succeed to run CI?

@fujunwei
Copy link
Collaborator

PTAL, thanks! @fujunwei @BruceDai The failure seems caused by getting baseline for regression check, since there is no real implementation to support test cases, the failure should be expected, right? If so, can we merge it? Then I think the next PR will succeed to run CI?

There are errors when running the end-to-end tests, please disable it if it's hard to fix:

[==========] Running 359 tests from 40 test suites.
[----------] Global test environment set-up.
unknown file: error: SEH exception with code 0xc0000005 thrown in auxiliary test code (environments or event listeners).

@mingmingtasd
Copy link
Collaborator Author

mingmingtasd commented Aug 16, 2022

PTAL, thanks! @fujunwei @BruceDai The failure seems caused by getting baseline for regression check, since there is no real implementation to support test cases, the failure should be expected, right? If so, can we merge it? Then I think the next PR will succeed to run CI?

There are errors when running the end-to-end tests, please disable it if it's hard to fix:

[==========] Running 359 tests from 40 test suites.
[----------] Global test environment set-up.
unknown file: error: SEH exception with code 0xc0000005 thrown in auxiliary test code (environments or event listeners).

OK, I have disabled end2end tests for dml backend. @fujunwei

@mingmingtasd
Copy link
Collaborator Author

Close this PR since DML backend implementation has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants