Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate baseline data script for operator with single input #78

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Generate baseline data script for operator with single input #78

merged 6 commits into from
Dec 18, 2024
+847 −0

Conversation

BruceDai
Copy link
Contributor

@BruceDai BruceDai commented May 29, 2024 •
edited
Loading

This PR includes

  1. generate baseline data script
  2. baseline data for softsign and gelu operators.

@huningxin @fdwr PTAL, thanks.

@BruceDai BruceDai changed the title Gen softsign baseline Generate baseline data for single input May 29, 2024
@BruceDai BruceDai changed the title Generate baseline data for single input Generate baseline data script for operator with single input May 29, 2024
fdwr
fdwr reviewed Jun 8, 2024
View reviewed changes
Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks B.

test/tools/README.md Outdated Show resolved Hide resolved
test/tools/README.md Outdated Show resolved Hide resolved
test/tools/gen-operator-with-single-input.js Outdated Show resolved Hide resolved
test/tools/resources/gelu.json Outdated Show resolved Hide resolved
test/tools/resources/softsign.json Outdated Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/utils.js Show resolved Hide resolved
huningxin
huningxin approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % Dwayne's comments, Thanks!

@fdwr
Copy link

fdwr commented Jul 29, 2024

Just noticed this is still open. Is it obviated by other changes?

@fdwr
Copy link

fdwr commented Nov 26, 2024

Is this applicable still @BruceDai ?

@BruceDai
Copy link
Contributor Author

BruceDai commented Dec 4, 2024

Is this applicable still @BruceDai ?

Apologize to forget update this PR and missed your previous reminder.
I'm working it , will submit a new commit ASAP.

@BruceDai
Copy link
Contributor Author

BruceDai commented Dec 9, 2024

@fdwr I updated commit to fix your comments, please take another review, thanks!

fdwr
fdwr reviewed Dec 10, 2024
View reviewed changes
test/tools/README.md Outdated Show resolved Hide resolved
test/tools/utils.js Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/utils.js Outdated Show resolved Hide resolved
test/tools/gen-operator-with-single-input.js Outdated Show resolved Hide resolved
test/tools/utils.js Show resolved Hide resolved
BruceDai
BruceDai commented Dec 11, 2024
View reviewed changes
Copy link
Contributor Author

@BruceDai BruceDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdwr Done to fix your new comments, please take another look, thanks! ☕

test/tools/gen-operator-with-single-input.js Outdated Show resolved Hide resolved
test/tools/utils.js Show resolved Hide resolved
test/tools/utils.js Show resolved Hide resolved
fdwr
fdwr approved these changes Dec 11, 2024
View reviewed changes
Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BruceDai BruceDai force-pushed the gen_softsign_baseline branch from d72f6fe to c4ef32b Compare December 17, 2024 01:50
fdwr
fdwr approved these changes Dec 17, 2024
View reviewed changes
Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 👍.

@huningxin huningxin merged commit 17e2727 into webmachinelearning:main Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

@huningxin huningxin huningxin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BruceDai @fdwr @huningxin