implement reverse #116
Open
implement reverse #116
+104
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
approved these changes
Dec 16, 2024
src/reverse.js
Outdated
| */ | ||
| export function reverse(input, {axes}) { | ||
| // reuse validateReduceParams to check parameters of reverse | ||
| validateReduceParams(input, {axes}); |
There was a problem hiding this comment.
If reverse had been added before reduce, would reduce call validateReverseParams? Renaming validateReduceParams to a more generic validateAxes would make sense.
BruceDai
force-pushed
the
add_reverse
branch
from
52307c8 to
b09c509
Compare
huningxin
reviewed
Dec 17, 2024
src/lib/validate-input.js
Outdated
| @@ -471,7 +471,10 @@ export function validatePool2dParams(input, _, {roundingType = 'floor'}) { | |||
| } | |||
| } | |||
|
|
|||
| export function validateReduceParams(input, {axes}) { | |||
| export function validateAxes(input, {axes}) { | |||
There was a problem hiding this comment.
Given the renaming, should it just take axes argument rather than an object containing axes attribute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fixe #110.
@fdwr @huningxin @shiyi9801 PTAL, thanks!