Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require full name for kvittering #1172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ShaileshS1702
Copy link

@ShaileshS1702 ShaileshS1702 commented Sep 26, 2024

Made a validator for name. Name now has to include a space.

I did also make it such that at least two of the names had to be more than 0 in length. This was added because writing your first name and just a space would validate you name while not being a real name. Initially , I did think about having two names with at least 2 letters (so not just initals) but could not find any sources on length of a name. ( In case we invalidate a name such as Å, even thought that is a persons full first or last name).

I do really appreciate input on this topic.

Resolves ABA-1075

Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I think this will do nicely, and if it should be too restrictive or too lax we can tweak it at a later point

Copy link

linear bot commented Sep 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants