Fix/player duration props [WTEL-4110 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JSIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Lera24
reviewed
May 16, 2024
| @@ -41,6 +41,10 @@ export default { | |||
| type: Boolean, | |||
| default: false, | |||
| }, | |||
| duration: { | |||
There was a problem hiding this comment.
а може isDuration? чи якось по іншому, бо тип булеан
І як новий проп кидаємо, то треба в доку зміни)
There was a problem hiding this comment.
це слушно, подивилась ще раз
Пропоную, все ж таки, залишити як є, бо інші пропса названі саме таким чином.
типу invertTime, download, autoplay
liza-pohranichna
changed the title
dlohvinov
approved these changes
May 16, 2024
liza-pohranichna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.