Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add 2fa[WTEL-4430] #72

Merged
merged 3 commits into from
May 16, 2024
Merged

feature: add 2fa[WTEL-4430] #72

merged 3 commits into from
May 16, 2024

Conversation

Lera24
Copy link
Contributor

@Lera24 Lera24 commented May 15, 2024

No description provided.

steps() {
return [
...mapState('auth', {
enabledTfa: (state) => state.enabledTfa,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfa?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabledTfa (Two Factor Authorization)
Раз така назва з беку приходить, я б її не змінювала)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а чому десь 2фа, а десь Тфа тоді?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2фа у url API та змінній enable_2FA
У enabledTfa 2 погано сприймається у назві на бекенді

src/components/auth/login/the-login.vue Outdated Show resolved Hide resolved
src/api/auth/auth.js Outdated Show resolved Hide resolved
src/store/modules/auth/auth.js Outdated Show resolved Hide resolved
src/store/modules/auth/auth.js Show resolved Hide resolved
src/api/auth/auth.js Show resolved Hide resolved
src/components/auth/login/the-login.vue Outdated Show resolved Hide resolved
src/components/auth/login/the-login.vue Outdated Show resolved Hide resolved
@dlohvinov dlohvinov merged commit 75c4963 into master May 16, 2024
1 check failed
@dlohvinov dlohvinov deleted the feature/add-2fa branch May 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants