Feat/ lookups - start page [WTEL-4740] #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlohvinov
requested changes
Sep 16, 2024
| <style lang="scss" scoped> | ||
| .start-page-card { | ||
| box-sizing: border-box; | ||
| width: 264px; |
There was a problem hiding this comment.
а це з Женею аппрували?
зазвичай коли треба вказати конкртений розмір в пікселях, то це помилка в макеті
| padding: var(--spacing-xs); | ||
| color: var(--text-main-color); | ||
| border-radius: var(--border-radius); | ||
| background-color: var(--content-wrapper-color); |
There was a problem hiding this comment.
| } | ||
| &__description { | ||
| @extend %typo-body-1; | ||
| height: 78px; |
Comment on lines
+74
to
+78
| &__button.wt-button.secondary{ | ||
| &:hover{ | ||
| background-color: var(--btn-primary-color); | ||
| } | ||
| } |
There was a problem hiding this comment.
тут шото теж не те, якщо треба лізти в компонент, значить, проблема з макетом
хіба що, можливо, треба робити це джаваскриптом, і міняти атрибут компонента, щоб не лізти в його внутрощі
|
|
||
| <script> | ||
|
|
||
| export default { |
There was a problem hiding this comment.
в црмці пишемо на композішенс апі -- під то заточено все
Comment on lines
+8
to
+9
| export default { | ||
| name: 'start-page-card', |
|
|
||
| <style lang="scss" scoped> | ||
| .start-page-logo{ | ||
| min-height: 200px; |
Comment on lines
+34
to
+36
| logo() { | ||
| return this.theme === 'dark' ? {src: '/crm/src/modules/start-page/assets/start-page-logo-dark.svg', alt: 'image alt'} | ||
| : {src: '/crm/src/modules/start-page/assets/start-page-logo-light.svg', alt: 'image alt'} |
There was a problem hiding this comment.
краще імпортнути файл і підставити тут
так як тут написано, я боюсь, віт не розбереться на білді і картинка загубиться, а якщо імпортнути -- то точно ні
| <style scoped> | ||
| .start-page-wrapper { | ||
| box-sizing: border-box; | ||
| min-width: 264px; |
| box-sizing: border-box; | ||
| min-width: 264px; | ||
| display: grid; | ||
| grid-template-columns: repeat(auto-fit, 264px); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.