Fix/custom ringtone validation [WTEL-4814] #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lera24
reviewed
Aug 1, 2024
| @@ -29,6 +29,7 @@ | |||
| :autoplay="false" | |||
| /> | |||
| <wt-button | |||
| :disabled="savedRingtone === ringtone.name" | |||
Lera24
approved these changes
Aug 2, 2024
dlohvinov
reviewed
Aug 5, 2024
| @@ -47,16 +48,20 @@ export default { | |||
| isCustomRingtone: false, | |||
| ringtone: {}, | |||
| options: [], | |||
| savedRingtone: undefined, // value from localStorage, we need undefined for comparison with ringtone.name when it | |||
There was a problem hiding this comment.
я так розумію, цей андефайнд необхідний для порівняння на стрічці 63
можливо, там можна просто додати перевірку на !!this.savedRingtone && ...===... ?
liza-pohranichna
commented
Aug 5, 2024
| isRingtoneSaved() { | ||
| return !this.savedRingtone && !this.ringtone.name // if was chosen default ringtone | ||
| || this.savedRingtone === this.ringtone.name; | ||
| } |
There was a problem hiding this comment.
внесла зміни ось тут
dlohvinov
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.