feature: refactoring of configuration-popup.vue and adding ExportSett… #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lera24
reviewed
Jun 24, 2024
src/app/locale/en/en.js
Outdated
| @@ -961,6 +961,13 @@ export default { | |||
| }, | |||
| }, | |||
|
|
|||
| configuration: { | |||
| configurationPopup: { | |||
| format: 'Format', | |||
| :v="v$.itemInstance.value" | ||
| :value="itemInstance.value" | ||
| required | ||
| @change="(event) => this.setItemProp({ prop: 'value', value: event })" |
There was a problem hiding this comment.
а чого саме стрілка тут потрібна?
| @input="selectHandler" | ||
| /> | ||
| <wt-input | ||
| v-if="itemInstance.format?.value === exportSettingsEnum.XLS" |
There was a problem hiding this comment.
краще у компьютед)
і нижче також)
| this.itemInstance.separator = inputValue; | ||
| this.handleDefaultSelectConfigInput(); | ||
| }, | ||
| handleDefaultSelectConfigInput() { |
There was a problem hiding this comment.
чисто попридиратись(
метод викликається раніше, може і перенести його вище в коді?)
|
|
||
| const ConfigurationTypeLookup = Object.freeze({ | ||
| [EngineSystemSettingName.EnableOmnichannel]: { | ||
| controls: [ |
There was a problem hiding this comment.
а це вірно що значення в масиві сховані?
Lera24
reviewed
Jun 24, 2024
| displayedConfigurationType() { | ||
| return { [this.valueType]: true }; | ||
| }, | ||
| isFormatXls() { |
There was a problem hiding this comment.
може isExportSettingsFormatXls?
Lera24
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ings config WTEL-4046