Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/team schemas [WTEL-4354] #649

Merged
merged 9 commits into from
Apr 19, 2024
Merged

Conversation

liza-pohranichna
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Apr 15, 2024

Qodana for JS

6 new problems were found

Inspection name Severity Problems
ESLint 🔴 Failure 5
Missing component import 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@liza-pohranichna liza-pohranichna requested a review from Lera24 April 16, 2024 17:36
@@ -717,6 +718,11 @@ export default {
agentStatus: 'Agent status changed',
}
},
schemas: {
schemas: 'Schema | Schemas',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А локаль з flow не підходить?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нєа ( в ососбистих обговорили)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

таке саме питання

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizacoma а тепер розкажіть мені, будь ласка)))

<template #title>
{{ itemInstance.id
? $tc('objects.ccenter.teams.schemas.editSchema')
: $tc('objects.ccenter.teams.schemas.addSchema') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А давай в computed або шаблонною строкою)

import openedObjectTableTabMixin
from '../../../../../../../app/mixins/objectPagesMixins/openedObjectTableTabMixin/openedObjectTableTabMixin';
import SchemaPopup from './opened-team-schema-popup.vue';
import WtItemLink from '@webitel/ui-sdk/src/components/wt-item-link/wt-item-link.vue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хіба імпорт потрібен?

@@ -1,23 +0,0 @@
import { shallowMount } from '@vue/test-utils';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а чого видалила?)

@@ -717,6 +718,11 @@ export default {
agentStatus: 'Agent status changed',
}
},
schemas: {
schemas: 'Schema | Schemas',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

таке саме питання

@@ -717,6 +718,11 @@ export default {
agentStatus: 'Agent status changed',
}
},
schemas: {
schemas: 'Schema | Schemas',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizacoma а тепер розкажіть мені, будь ласка)))

@sort="sort"
>
<template #schema="{ item }">
<wt-item-link :link="`/routing/flow/${item.schema.id}`">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а не можна роут нейм використати?

@@ -124,6 +124,7 @@ export default {
back: 'Back',
change: 'Change',
name: 'Name',
title: 'Title',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а такої локалі в лібі немає?

});

const getTeamFlowsList = async (params) => {
console.log();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

v$: useVuelidate(),
}),
data: () => ({
namespace: 'ccenter/teams/flowSchemas',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а основний флов стор теж називається зі словом схемас?
я не пригадую, але здається, що ні(

@liza-pohranichna liza-pohranichna merged commit 0bb5959 into master Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants