-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/team schemas [WTEL-4354] #649
Conversation
Qodana for JS6 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
src/app/locale/en/en.js
Outdated
@@ -717,6 +718,11 @@ export default { | |||
agentStatus: 'Agent status changed', | |||
} | |||
}, | |||
schemas: { | |||
schemas: 'Schema | Schemas', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А локаль з flow не підходить?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нєа ( в ососбистих обговорили)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
таке саме питання
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lizacoma а тепер розкажіть мені, будь ласка)))
<template #title> | ||
{{ itemInstance.id | ||
? $tc('objects.ccenter.teams.schemas.editSchema') | ||
: $tc('objects.ccenter.teams.schemas.addSchema') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А давай в computed або шаблонною строкою)
import openedObjectTableTabMixin | ||
from '../../../../../../../app/mixins/objectPagesMixins/openedObjectTableTabMixin/openedObjectTableTabMixin'; | ||
import SchemaPopup from './opened-team-schema-popup.vue'; | ||
import WtItemLink from '@webitel/ui-sdk/src/components/wt-item-link/wt-item-link.vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Хіба імпорт потрібен?
@@ -1,23 +0,0 @@ | |||
import { shallowMount } from '@vue/test-utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а чого видалила?)
src/app/locale/en/en.js
Outdated
@@ -717,6 +718,11 @@ export default { | |||
agentStatus: 'Agent status changed', | |||
} | |||
}, | |||
schemas: { | |||
schemas: 'Schema | Schemas', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
таке саме питання
src/app/locale/en/en.js
Outdated
@@ -717,6 +718,11 @@ export default { | |||
agentStatus: 'Agent status changed', | |||
} | |||
}, | |||
schemas: { | |||
schemas: 'Schema | Schemas', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lizacoma а тепер розкажіть мені, будь ласка)))
@sort="sort" | ||
> | ||
<template #schema="{ item }"> | ||
<wt-item-link :link="`/routing/flow/${item.schema.id}`"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а не можна роут нейм використати?
@@ -124,6 +124,7 @@ export default { | |||
back: 'Back', | |||
change: 'Change', | |||
name: 'Name', | |||
title: 'Title', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а такої локалі в лібі немає?
}); | ||
|
||
const getTeamFlowsList = async (params) => { | ||
console.log(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
v$: useVuelidate(), | ||
}), | ||
data: () => ({ | ||
namespace: 'ccenter/teams/flowSchemas', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а основний флов стор теж називається зі словом схемас?
я не пригадую, але здається, що ні(
No description provided.