Feature/teams hooks [WTEL-4246] #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JS8 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Lera24
reviewed
Mar 26, 2024
| <template #main> | ||
| <form> | ||
| <wt-select | ||
| v-model="event" |
There was a problem hiding this comment.
зроби будь ласка через велью)
| } : {}; | ||
| }, | ||
| set(value) { | ||
| this.setItemProp({ prop: 'event', value: value.value }); |
There was a problem hiding this comment.
Тут можна деструктурізацію зробити)
| subNamespace: 'hooks', | ||
| isHookPopup: false, | ||
|
|
||
| isDeleteConfirmation: false, |
There was a problem hiding this comment.
Тут не вийде додати useDeleteConfirmationPopup?
| @@ -0,0 +1,105 @@ | |||
| <template> | |||
There was a problem hiding this comment.
А цей попап чимось відрізняється від того що в чергах?
Може винести один загальний компонент, ніж дублювати?
| @@ -0,0 +1,3 @@ | |||
| export default Object.freeze({ | |||
| AGENT_STATUS: 'agent_status', | |||
There was a problem hiding this comment.
Це вірно, що він відрізняється від того що в чергах?
| value: 'state', | ||
| locale: 'reusable.state', | ||
| field: 'enabled', | ||
| width: '100px', |
mistakenly created file
… into feature/teams-hooks
dlohvinov
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.