Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/api refactoring roles [WTEL-3630] #478

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Feature/api refactoring roles [WTEL-3630] #478

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ecddbe8
feature: refactoring reles api in progress [WTEL-3630]
liza-pohranichna Jul 10, 2023
b004b3d
feature: roles api refactoring [WTEL-3630]
lizacoma Jul 11, 2023
bf3305a
feature: roles api refactoring [WTEL-3630]
lizacoma Jul 11, 2023
8e73bbb
feature: roles api refactoring [WTEL-3630]
lizacoma Jul 11, 2023
f99570e
feature: roles api refactoring [WTEL-3630]
lizacoma Jul 12, 2023
0b88384
Merge branch 'master' into feature/api-refactoring-roles
lizacoma Nov 6, 2023
29507ac
feature: refactor in progress [WTEL-3630]
lizacoma Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
234 changes: 180 additions & 54 deletions src/modules/permissions/modules/roles/api/roles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,71 +1,197 @@
import ApplicationsAccess
from '@webitel/ui-sdk/src/modules/Userinfo/classes/ApplicationsAccess';
import deepCopy from 'deep-copy';
import {
EndpointCreatorApiConsumer,
EndpointDeleterApiConsumer,
EndpointGetterApiConsumer,
EndpointListGetterApiConsumer,
EndpointUpdaterApiConsumer,
} from 'webitel-sdk/esm2015/api-consumers';
import instance from '../../../../../app/api/old/instance';
getDefaultGetListResponse,
getDefaultGetParams,
} from '@webitel/ui-sdk/src/api/defaults';
import applyTransform, {
camelToSnake,
merge, notify, snakeToCamel,
starToSearch, log, sanitize,
generateUrl,
} from '@webitel/ui-sdk/src/api/transformers';
import deepCopy from 'deep-copy';
import ApplicationsAccess from '@webitel/ui-sdk/src/modules/Userinfo/classes/ApplicationsAccess';
import instance from '../../../../../app/api/instance';

const baseUrl = '/roles';

const fieldsToSend = ['name', 'description', 'permissions', 'metadata'];

const defaultSingleObject = {
name: '',
description: '',
permissions: [],
metadata: {},
const preRequestHandler = (item) => {
const copy = deepCopy(item);
copy.metadata.access = ApplicationsAccess.minify(copy.metadata.access);
return copy;
};

const itemResponseHandler = (item) => {
// eslint-disable-next-line no-param-reassign
item.metadata.access = new ApplicationsAccess({ access: item.metadata.access }).getAccess();
return item;
const getRoleList = async (params) => {
const fieldsToSend = ['page', 'size', 'q', 'sort', 'fields', 'id'];

const url = applyTransform(params, [
merge(getDefaultGetParams()),
starToSearch('search'),
(params) => ({ ...params, q: params.search }),
sanitize(fieldsToSend),
camelToSnake(),
generateUrl(baseUrl),
]);
try {
const response = await instance.get(url);
const { items, next } = applyTransform(response.data, [
snakeToCamel(),
merge(getDefaultGetListResponse()),
]);
return {
items,
next,
};
} catch (err) {
throw applyTransform(err, [
notify,
]);
}
};

const preRequestHandler = (item) => {
const itemCopy = deepCopy(item);
itemCopy.metadata.access = ApplicationsAccess.minify(item.metadata.access);
return itemCopy;
const getRole = async ({ itemId: id }) => {
const defaultObject = {
name: '',
description: '',
permissions: [],
metadata: {},
};

const itemResponseHandler = (response) => {
const copy = deepCopy(response);
copy.metadata.access = new ApplicationsAccess({ access: copy.metadata.access }).getAccess();
return copy;
};

const url = `${baseUrl}/${id}`;

try {
const response = await instance.get(url);
return applyTransform(response.data, [
snakeToCamel(),
merge(defaultObject),
itemResponseHandler,
]);
} catch (err) {
throw applyTransform(err, [
notify,
]);
}
};

const getExtendedRoles = async (params) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а чим цей метод від гет ліста звичайного відрізняється?
було би круто знайти і розібратись

const fieldsToSend = ['page', 'size', 'q', 'sort', 'fields', 'id'];

const url = applyTransform(params, [
merge(getDefaultGetParams()),
starToSearch('search'),
(params) => ({ ...params, q: params.search }),
sanitize(fieldsToSend),
camelToSnake(),
generateUrl(baseUrl),
]);
try {
const response = await instance.get(url);
const { items, next } = applyTransform(response.data, [
snakeToCamel(),
merge(getDefaultGetListResponse()),
]);
return {
items,
next,
};
} catch (err) {
throw applyTransform(err, [
notify,
]);
}
};

const addRole = async ({ itemInstance }) => {
const item = applyTransform(itemInstance, [
preRequestHandler,
sanitize(fieldsToSend),
camelToSnake(),
]);
try {
const response = await instance.post(baseUrl, item);
return applyTransform(response.data, [
snakeToCamel(),
]);
} catch (err) {
throw applyTransform(err, [
notify,
]);
}
};

const updateRole = async ({ itemInstance, itemId: id }) => {
const item = applyTransform(itemInstance, [
preRequestHandler,
log,
sanitize(fieldsToSend),
camelToSnake(),
]);

const url = `${baseUrl}/${id}`;
try {
const response = await instance.put(url, item);
return applyTransform(response.data, [
snakeToCamel(),
]);
} catch (err) {
throw applyTransform(err, [
notify,
]);
}
};

const listGetter = new EndpointListGetterApiConsumer({ baseUrl, instance });
const itemGetter = new EndpointGetterApiConsumer(
{ baseUrl, instance },
{ defaultSingleObject, itemResponseHandler },
);
const extendedRolesListGetter = new EndpointListGetterApiConsumer({
baseUrl,
instance,
const deleteRole = async ({ id }) => {
const url = `${baseUrl}/${id}`;
try {
const response = await instance.delete(url);
return applyTransform(response.data, []);
} catch (err) {
throw applyTransform(err, [
notify,
]);
}
};

const getRolesLookup = (params) => getRoleList({
...params,
fields: params.fields || ['id', 'name'],
});
const itemCreator = new EndpointCreatorApiConsumer(
{ baseUrl, instance },
{ fieldsToSend, preRequestHandler },
);
const itemUpdater = new EndpointUpdaterApiConsumer(
{ baseUrl, instance },
{ fieldsToSend, preRequestHandler },
);
const itemDeleter = new EndpointDeleterApiConsumer({ baseUrl, instance });

const PERMISSIONS_LIST_URL = '/permissions';
const permissionsListGetter = new EndpointListGetterApiConsumer(
{ baseUrl: PERMISSIONS_LIST_URL, instance },
);

const getRoleList = (params) => listGetter.getList(params);
const getExtendedRoles = (params) => extendedRolesListGetter.getList(params);
const getRole = (params) => itemGetter.getItem(params);
const addRole = (params) => itemCreator.createItem(params);
const updateRole = (params) => itemUpdater.updateItem(params);
const deleteRole = (params) => itemDeleter.deleteItem(params);
const getRolesLookup = (params) => listGetter.getLookup(params);

const getPermissionsOptions = (payload) => permissionsListGetter.getList(payload);

const getPermissionsOptions = async (params) => {
const fieldsToSend = ['page', 'size', 'q', 'sort', 'fields', 'id'];

const url = applyTransform(params, [
merge(getDefaultGetParams()),
starToSearch('search'),
(params) => ({ ...params, q: params.search }),
sanitize(fieldsToSend),
camelToSnake(),
generateUrl(PERMISSIONS_LIST_URL),
]);
try {
const response = await instance.get(url);
const { items, next } = applyTransform(response.data, [
snakeToCamel(),
merge(getDefaultGetListResponse()),
]);
return {
items,
next,
};
} catch (err) {
throw applyTransform(err, [
notify,
]);
}
};

const RolesAPI = {
getList: getRoleList,
Expand Down